Skip to content

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Jan 25, 2025

Fixes #294

It also updates the hdr histogram dependency to make usage of 2 optimizations we've added there quite a while ago:

Altogether, we've reverted the regression introduced in v2.1.1 and also reduced by 22% the CPU usage for the same QPS (even a bit higher).

Sample benchmark command:

./memtier_benchmark --hide-histogram --pipeline=1 -c 100 -t 100 -d 1000 --key-maximum=9625503 --key-pattern=R:R --ratio=1:0  --test-time=60

CPU usage fix and improvement (red is this PR) :
10K connections,CPU per version (lower better)

Ops/sec fix and improvement (red is this PR) :

10K connections, ops_sec per version (higher better)

…nd by using hdr_value_at_percentiles() instead of N x hdr_value_at_percentile().
@filipecosta90 filipecosta90 merged commit 9095d98 into RedisLabs:master Jan 29, 2025
7 checks passed
@filipecosta90 filipecosta90 deleted the optimize.summarize_quantiles branch January 29, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

summarize_current_second -> hdr_value_at_percentile takes large ammount of cpu cycles on large thread count

2 participants