Skip to content

Conversation

filipecosta90
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20c013d) 64.53% compared to head (b3568d8) 64.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files          21       21           
  Lines        4368     4368           
=======================================
  Hits         2819     2819           
  Misses       1549     1549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yossigo
Copy link
Contributor

yossigo commented Jan 23, 2024

@filipecosta90 Did you consider fixing the issues themselves? I think it should be fairly simple and still backward compatible, so overall preferred over changing compiler flags.

@filipecosta90 filipecosta90 changed the title Specifying the C++ standard version to avoid deprecation/failures on build in case of new standard usage Fixed deprecated and casting build errors caught on recent compilers Jan 23, 2024
@filipecosta90
Copy link
Collaborator Author

@filipecosta90 Did you consider fixing the issues themselves? I think it should be fairly simple and still backward compatible, so overall preferred over changing compiler flags.

Indeed. Addressed in the latest commit @yossigo

yossigo
yossigo previously approved these changes Jan 23, 2024
Co-authored-by: Yossi Gottlieb <yossigo@gmail.com>
@filipecosta90 filipecosta90 requested a review from yossigo January 23, 2024 15:07
@filipecosta90 filipecosta90 merged commit 104ed9f into master Jan 23, 2024
@filipecosta90 filipecosta90 deleted the std.cpp98 branch January 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when building on MacOS arm64-apple-darwin21.6.0

2 participants