Skip to content

Conversation

@chayim
Copy link
Contributor

@chayim chayim commented May 23, 2021

Migrating the redisjson build to match the newer/modern build system used by the other clients. This now relies on tox, pypoetry for dependencies, and builds in parallel on our supported platforms. I also added instructions to the READMEs.

@chayim chayim changed the title modern take 1 modern python builds May 23, 2021
@chayim chayim marked this pull request as ready for review May 23, 2021 06:55
@chayim chayim requested a review from gkorland May 23, 2021 06:55
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2021

This pull request fixes 2 alerts when merging 79fbae6 into 2de5c29 - view on LGTM.com

fixed alerts:

  • 1 for Missing call to `__del__` during object destruction
  • 1 for Missing call to `__init__` during object initialization

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented May 23, 2021

This pull request fixes 2 alerts when merging d34ecae into 2de5c29 - view on LGTM.com

fixed alerts:

  • 1 for Missing call to `__del__` during object destruction
  • 1 for Missing call to `__init__` during object initialization

@gkorland gkorland merged commit 05c036f into master May 23, 2021
@gkorland gkorland deleted the ck-modern-python branch May 23, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants