Skip to content

structure execution plan#148

Merged
swilly22 merged 20 commits into
masterfrom
structure-execution-plan
Dec 5, 2021
Merged

structure execution plan#148
swilly22 merged 20 commits into
masterfrom
structure-execution-plan

Conversation

@AviAvni

@AviAvni AviAvni commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Nov 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #148 (247b3f2) into master (7d8caae) will decrease coverage by 1.16%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   86.18%   85.02%   -1.17%     
==========================================
  Files           8        9       +1     
  Lines         543      621      +78     
==========================================
+ Hits          468      528      +60     
- Misses         75       93      +18     
Impacted Files Coverage Δ
redisgraph/execution_plan.py 77.21% <77.21%> (ø)
redisgraph/graph.py 87.76% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8caae...247b3f2. Read the comment docs.

Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py Outdated
Comment thread redisgraph/execution_plan.py Outdated
Comment thread redisgraph/execution_plan.py Outdated
Comment thread tests/functional/test_all.py Outdated
@lgtm-com

lgtm-com Bot commented Nov 17, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 94014c3 into 6283891 - view on LGTM.com

new alerts:

  • 1 for Comparison of identical values

@lgtm-com

lgtm-com Bot commented Nov 17, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 7b83651 into 6283891 - view on LGTM.com

new alerts:

  • 1 for Comparison of identical values

@lgtm-com

lgtm-com Bot commented Nov 17, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging c5d7a51 into 6283891 - view on LGTM.com

new alerts:

  • 1 for Comparison of identical values

Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py
Comment thread redisgraph/execution_plan.py Outdated
Comment thread redisgraph/execution_plan.py Outdated
Comment thread tests/functional/test_all.py
Comment thread tests/functional/test_all.py
@lgtm-com

lgtm-com Bot commented Nov 21, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging fa56af0 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@lgtm-com

lgtm-com Bot commented Nov 22, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 92b8b88 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@swilly22 swilly22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few of my previous comments weren't addressed.

Comment thread redisgraph/execution_plan.py Outdated
Comment thread redisgraph/execution_plan.py Outdated
@lgtm-com

lgtm-com Bot commented Nov 22, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 2a18643 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@lgtm-com

lgtm-com Bot commented Nov 22, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging ef428b2 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@lgtm-com

lgtm-com Bot commented Nov 22, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 412393a into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@lgtm-com

lgtm-com Bot commented Nov 22, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 94af356 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

swilly22
swilly22 previously approved these changes Nov 23, 2021
@lgtm-com

lgtm-com Bot commented Nov 23, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 24a6bc2 into 7d8caae - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@sonarqubecloud

sonarqubecloud Bot commented Dec 5, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swilly22 swilly22 merged commit b27bc08 into master Dec 5, 2021
@swilly22 swilly22 deleted the structure-execution-plan branch December 5, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants