Skip to content

map datatype #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redisgraph/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def merge(self, pattern):
return self.query(query)

# Procedures.
def call_procedure(self, procedure, read_only=False, *args, **kwagrs):
def call_procedure(self, procedure, *args, read_only=False, **kwagrs):
args = [quote_string(arg) for arg in args]
q = 'CALL %s(%s)' % (procedure, ','.join(args))

Expand Down
33 changes: 27 additions & 6 deletions redisgraph/query_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from .exceptions import VersionMismatchException
from prettytable import PrettyTable
from redis import ResponseError
from collections import OrderedDict

LABELS_ADDED = 'Labels added'
NODES_CREATED = 'Nodes created'
Expand Down Expand Up @@ -39,6 +40,7 @@ class ResultSetScalarTypes:
VALUE_EDGE = 7
VALUE_NODE = 8
VALUE_PATH = 9
VALUE_MAP = 10


class QueryResult:
Expand Down Expand Up @@ -125,6 +127,14 @@ def parse_entity_properties(self, props):

return properties

def parse_string(self, cell):
if isinstance(cell, bytes):
return cell.decode()
elif not isinstance(cell, str):
return str(cell)
else:
return cell

def parse_node(self, cell):
# Node ID (integer),
# [label string offset (integer)],
Expand Down Expand Up @@ -156,6 +166,19 @@ def parse_path(self, cell):
edges = self.parse_scalar(cell[1])
return Path(nodes, edges)

def parse_map(self, cell):
m = OrderedDict()
n_entries = len(cell)

# A map is an array of key value pairs.
# 1. key (string)
# 2. array: (value type, value)
for i in range(0, n_entries, 2):
key = self.parse_string(cell[i])
m[key] = self.parse_scalar(cell[i+1])

return m

def parse_scalar(self, cell):
scalar_type = int(cell[0])
value = cell[1]
Expand All @@ -165,12 +188,7 @@ def parse_scalar(self, cell):
scalar = None

elif scalar_type == ResultSetScalarTypes.VALUE_STRING:
if isinstance(value, bytes):
scalar = value.decode()
elif not isinstance(value, str):
scalar = str(value)
else:
scalar = value
scalar = self.parse_string(value)

elif scalar_type == ResultSetScalarTypes.VALUE_INTEGER:
scalar = int(value)
Expand Down Expand Up @@ -202,6 +220,9 @@ def parse_scalar(self, cell):
elif scalar_type == ResultSetScalarTypes.VALUE_PATH:
scalar = self.parse_path(value)

elif scalar_type == ResultSetScalarTypes.VALUE_MAP:
scalar = self.parse_map(value)

elif scalar_type == ResultSetScalarTypes.VALUE_UNKNOWN:
print("Unknown scalar type\n")

Expand Down
13 changes: 13 additions & 0 deletions tests/functional/test_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,19 @@ def test_param(self):
# All done, remove graph.
redis_graph.delete()

def test_map(self):
redis_graph = Graph('map', self.r)

query = "RETURN {a:1, b:'str', c:NULL, d:[1,2,3], e:True, f:{x:1, y:2}}"

actual = redis_graph.query(query).result_set[0][0]
expected = {'a': 1, 'b': 'str', 'c': None, 'd': [1, 2, 3], 'e': True, 'f': {'x': 1, 'y': 2}}

self.assertEqual(actual, expected)

# All done, remove graph.
redis_graph.delete()

def test_index_response(self):
redis_graph = Graph('social', self.r)

Expand Down