-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dockerfiles for Nvidia Jetson devices #18
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 39fe29a into 3ed59e3 - view on LGTM.com new alerts:
|
app/Dockerfile.jetson
Outdated
ENV LD_PRELOAD /usr/lib/aarch64-linux-gnu/libgomp.so.1 | ||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
RUN apt-get -qq update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN apt-get -qq update | |
RUN apt-get -qq update && apt-get install -qqy python3-distutils patch |
app/Dockerfile.jetson
Outdated
|
||
RUN apt-get -qq update | ||
|
||
RUN set -ex ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN wget -q https://bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py && python3 /tmp/get-pip.p3
camera/Dockerfile.jetson
Outdated
|
||
RUN apt-get -qq update && apt-get upgrade -y | ||
|
||
RUN set -x; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN apt-get install -yqq curl patch
camera/Dockerfile.jetson
Outdated
|
||
RUN set -x; \ | ||
apt-get install -y curl patch; \ | ||
curl https://bootstrap.pypa.io/get-pip.py -o /tmp/get-pip.py ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN wget -q bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py && python3 /tmp/get-pip.p3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. We should silence the output of apt along the way.
This pull request introduces 1 alert when merging 5436ca8 into 3ed59e3 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 65f1b10 into 3ed59e3 - view on LGTM.com new alerts:
|
self.install("python3-regex") | ||
self.install("python3-psutil python3-networkx python3-numpy") # python3-skimage | ||
- self.install_git_lfs_on_linux() | ||
+ # self.install_git_lfs_on_linux() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RedisAI 1.0.2 installs git lfs only for for x86 (it is fixed in future versions):
Therefore, Dockerfile installs it separately:
redis/Dockerfile.jetson
Outdated
ENV NVIDIA_VISIBLE_DEVICES all | ||
ENV NVIDIA_DRIVER_CAPABILITIES compute,utility | ||
|
||
RUN if [ ! -z $(command -v apt-get) ]; then apt-get -qq update; apt-get -q install -y libgomp1 build-essential libatlas-base-dev cmake ; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using semi-colons (;) to separate commands, try &&. This was if anything within the command fails, it fails.
redis/Dockerfile.jetson
Outdated
ENV NVIDIA_DRIVER_CAPABILITIES compute,utility | ||
|
||
RUN if [ ! -z $(command -v apt-get) ]; then apt-get -qq update; apt-get -q install -y libgomp1 build-essential libatlas-base-dev cmake ; fi | ||
RUN if [ ! -z $(command -v yum) ]; then yum install -y libgomp; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using semi-colons (;) to separate commands, try &&. This was if anything within the command fails, it fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-ampersands, and suggested changes. Otherwise stamped.
This pull request introduces 1 alert when merging adb1a00 into 3ed59e3 - view on LGTM.com new alerts:
|
No description provided.