Skip to content

bloom client + tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 12, 2019
Merged

bloom client + tests #1

merged 13 commits into from
Jun 12, 2019

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jun 6, 2019

No description provided.

@ashtul ashtul requested a review from mnunberg June 6, 2019 11:16
@ashtul
Copy link
Contributor Author

ashtul commented Jun 11, 2019

@itamarhaber would you be kind enough to review this shiny python client for RedisBloom?

@ashtul ashtul requested review from itamarhaber and removed request for mnunberg June 11, 2019 07:04
@codecov-io
Copy link

codecov-io commented Jun 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4172579). Click here to learn what that means.
The diff coverage is 98.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   98.83%           
=========================================
  Files             ?        2           
  Lines             ?      344           
  Branches          ?        0           
=========================================
  Hits              ?      340           
  Misses            ?        4           
  Partials          ?        0
Impacted Files Coverage Δ
test_commands.py 100% <100%> (ø)
redisbloom/client.py 98.08% <98.08%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4172579...c0dde42. Read the comment docs.

itamarhaber
itamarhaber approved these changes Jun 11, 2019
View reviewed changes
Copy link

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok after a cursory skim 👍

@gkorland gkorland merged commit 1ae634d into master Jun 12, 2019
@gkorland gkorland deleted the dev branch June 12, 2019 08:08
@ashtul ashtul restored the dev branch June 13, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamarhaber itamarhaber itamarhaber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashtul @codecov-io @itamarhaber @gkorland