Support AI.SCRIPTEXECUTE and AI.MODELEXECUTE #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 92.85% 93.46% +0.61%
==========================================
Files 6 6
Lines 546 597 +51
==========================================
+ Hits 507 558 +51
Misses 26 26
Partials 13 13
Continue to review full report at Codecov.
|
AvitalFineRedis
changed the title
yes :) |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
| func getTLSdetails() (tlsready bool, tls_cert string, tls_key string, tls_cacert string) { | ||
| func getTLSdetails() (tlsready bool, tls_cert, tls_key, tls_cacert string) { |
There was a problem hiding this comment.
don't use underscores in Go names; func result tls_cacert should be tlsCacert
don't use underscores in Go names; func result tls_cert should be tlsCert
don't use underscores in Go names; func result tls_key should be tlsKey
| } | ||
|
|
||
| func getTLSdetails() (tlsready bool, tls_cert string, tls_key string, tls_cacert string) { | ||
| func getTLSdetails() (tlsready bool, tls_cert, tls_key, tls_cacert string) { |
There was a problem hiding this comment.
don't use underscores in Go names; func result tls_cacert should be tlsCacert
don't use underscores in Go names; func result tls_cert should be tlsCert
don't use underscores in Go names; func result tls_key should be tlsKey
| } | ||
|
|
||
| func getTLSdetails() (tlsready bool, tls_cert string, tls_key string, tls_cacert string) { | ||
| func getTLSdetails() (tlsready bool, tls_cert, tls_key, tls_cacert string) { |
There was a problem hiding this comment.
don't use underscores in Go names; func result tls_cacert should be tlsCacert
don't use underscores in Go names; func result tls_cert should be tlsCert
don't use underscores in Go names; func result tls_key should be tlsKey
| return | ||
| } | ||
|
|
||
| func (c *Client) LoadBackend(backend_identifier, location string) (err error) { |
There was a problem hiding this comment.
don't use underscores in Go names; method parameter backend_identifier should be backendIdentifier
exported method Client.LoadBackend should have comment or be unexported
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| func getTLSdetails() (tlsready bool, tls_cert string, tls_key string, tls_cacert string) { | ||
| func getTLSdetails() (tlsready bool, tls_cert, tls_key, tls_cacert string) { |
There was a problem hiding this comment.
don't use underscores in Go names; func result tls_cacert should be tlsCacert
don't use underscores in Go names; func result tls_cert should be tlsCert
don't use underscores in Go names; func result tls_key should be tlsKey
| } | ||
|
|
||
| func ProcessTensorGetReply(reply interface{}, errIn error) (err error, dtype string, shape []int64, data interface{}) { | ||
| func ProcessTensorGetReply(reply interface{}, errIn error) (dtype string, shape []int64, data interface{}, err error) { |
There was a problem hiding this comment.
exported function ProcessTensorGetReply should have comment or be unexported
2 participants
Add support for AI.SCRIPTEXECUTE and AI.MODELEXECUTE commands.
Also added support to
minbatchtimeoutto the model interface (included in ModelGet command).