Skip to content

Add BATCHSIZE, MINBATCHSIZE, INPUTS and OUTPUTS to ModelGet #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 26, 2021
Merged

Add BATCHSIZE, MINBATCHSIZE, INPUTS and OUTPUTS to ModelGet #42

merged 12 commits into from
Aug 26, 2021

Conversation

@AvitalFineRedis
Copy link
Contributor

No description provided.

@AvitalFineRedis AvitalFineRedis linked an issue Aug 24, 2021 that may be closed by this pull request
Support for BATCHSIZE, MINBATCHSIZE, INPUTS and OUTPUTS on AI.MODELGET #24
Closed
@AvitalFineRedis
Copy link
Contributor Author

The failures here are handled in #41

filipecosta90
filipecosta90 requested changes Aug 25, 2021
View reviewed changes
AvitalFineRedis and others added 7 commits August 25, 2021 15:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 26, 2021 •
edited
Loading

Codecov Report

Merging #42 (955e1d9) into master (1819fa9) will increase coverage by 0.51%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   91.82%   92.33%   +0.51%     
==========================================
  Files           6        6              
  Lines         526      535       +9     
==========================================
+ Hits          483      494      +11     
+ Misses         28       27       -1     
+ Partials       15       14       -1
Impacted Files Coverage Δ
redisai/model.go 95.74% <92.30%> (+2.80%) ⬆️
redisai/commands.go 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1819fa9...955e1d9. Read the comment docs.

@filipecosta90 filipecosta90 added the enhancement New feature or request label Aug 26, 2021
@AvitalFineRedis AvitalFineRedis merged commit 0de1f60 into master Aug 26, 2021
@AvitalFineRedis AvitalFineRedis deleted the update_AI.MODELGET branch August 26, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filipecosta90 filipecosta90 filipecosta90 approved these changes

@alonre24 alonre24 Awaiting requested review from alonre24

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for BATCHSIZE, MINBATCHSIZE, INPUTS and OUTPUTS on AI.MODELGET

2 participants

@AvitalFineRedis @filipecosta90