[1.0] CircleCI: added QA automation (#660)

Author: rafie

.circleci/config.yml

@@ -143,7 +143,7 @@ jobs:
 
   build-and-test:
     docker:
-      - image: redisfab/rmbuilder:6.0.9-x64-buster
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
     steps:
       - build-steps:
           platform: debian
@@ -159,7 +159,7 @@ jobs:
 
   coverage:
     docker:
-      - image: redisfab/rmbuilder:6.0.9-x64-buster
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
     steps:
       - abort_for_docs
       - checkout
@@ -180,12 +180,45 @@ jobs:
           name: Build for coverage
           command: |
             make -C opt all COV=1 SHOW=1
-#      - run:
-#          name: Test with coverage
-#          command: |
-#            make -C opt test SHOW=1 COV=1 CLUSTER=1
-#            make -C opt cov-upload
-#          no_output_timeout: 30m
+      - run:
+          name: Test with coverage
+          command: |
+            make -C opt test SHOW=1 COV=1 CLUSTER=1
+            make -C opt cov-upload
+          no_output_timeout: 30m
+
+  valgrind:
+    parameters:
+      test_args:
+        type: string
+        default: "CLUSTER=0 AOF=0"
+    docker:
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
+    steps:
+      - abort_for_docs
+      - checkout
+      - run:
+          name: Submodule checkout
+          command: git submodule update --init --recursive
+      - restore_cache:
+          keys:
+          - build-dependencies-{{ checksum "get_deps.sh" }}
+          # If no exact match is found will get dependencies from source
+      - setup-automation
+      - run:
+          name: Install dependencies
+          command: |
+            ./opt/readies/bin/getredis -v 6 --valgrind --force
+            ./get_deps.sh cpu
+      - run:
+          name: Build for valgrind
+          command: |
+            make -C opt all VALGRIND=1 SHOW=1
+      - run:
+          name: Test with valgrind
+          command: |
+            make -C opt test VALGRIND=1 <<parameters.test_args>>
+          no_output_timeout: 120m
 
   build-macos:
     macos:
@@ -262,7 +295,7 @@ jobs:
       location:
         type: string
     docker:
-      - image: redisfab/rmbuilder:6.0.9-x64-buster
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
     steps:
       - abort_for_docs
       - early_return_for_forked_pull_requests
@@ -278,7 +311,7 @@ jobs:
 
   deploy-snapshot:
     docker:
-      - image: redisfab/rmbuilder:6.0.9-x64-buster
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
     steps:
       - abort_for_docs
       - early_return_for_forked_pull_requests
@@ -299,7 +332,7 @@ jobs:
 
   deploy-release:
     docker:
-      - image: redisfab/rmbuilder:6.0.9-x64-buster
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
     steps:
       - abort_for_docs
       - early_return_for_forked_pull_requests
@@ -313,6 +346,26 @@ jobs:
               aws s3 cp --no-progress $f s3://redismodules/$PACKAGE_NAME/ --acl public-read
             done
 
+  release-automation:
+    docker:
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
+    steps:
+      - checkout
+      - setup-automation
+      - run:
+          name: Run QA Automation
+          command: MODULE_VERSION=$CIRCLE_TAG VERBOSE=1 TEST=release ./tests/qa/run
+
+  nightly-automation:
+    docker:
+      - image: redisfab/rmbuilder:6.2.1-x64-buster
+    steps:
+      - checkout
+      - setup-automation
+      - run:
+          name: Run QA Automation
+          command: MODULE_VERSION=$CIRCLE_BRANCH VERBOSE=1 TEST=nightly QUICK=1 ./tests/qa/run
+
 
 on-any-branch: &on-any-branch
   filters:
@@ -341,6 +394,17 @@ on-integ-branch: &on-integ-branch
       only:
         - master
         - /^\d+\.\d+.*$/
+        - /^feature-.*$/
+    tags:
+      ignore: /.*/
+
+not-on-integ-branch: &not-on-integ-branch
+  filters:
+    branches:
+      ignore:
+        - master
+        - /^\d+\.\d+.*$/
+        - /^feature-.*$/
     tags:
       ignore: /.*/
 
@@ -357,6 +421,7 @@ on-integ-and-version-tags: &on-integ-and-version-tags
       only:
         - master
         - /^\d+\.\d+.*$/
+        - /^feature-.*$/
     tags:
       only: /^v[0-9].*/
 
@@ -403,6 +468,11 @@ workflows:
           context: common
           <<: *after-platform-builds
           <<: *on-version-tags
+      - release-automation:
+          context: common
+          <<: *on-version-tags
+          requires:
+            - deploy-release
 
   nightly:
     triggers:
@@ -414,3 +484,5 @@ workflows:
     jobs:
       - build-macos:
           <<: *never # temporarily disabled
+      - nightly-automation:
+          context: common

Dockerfile

@@ -40,20 +40,18 @@ RUN if [ "$DEPS_ARGS" = "" ]; then ./get_deps.sh cpu; else env $DEPS_ARGS ./get_
 
 ARG BUILD_ARGS=""
 ADD ./ /build
-RUN bash -c "set -e ;\
-    . ./opt/readies/bin/sourced ./profile.d ;\
-    make -C opt build $BUILD_ARGS SHOW=1"
+RUN bash -l -c "make -C opt build $BUILD_ARGS SHOW=1"
 
 ARG PACK
 ARG TEST
 
 RUN mkdir -p bin/artifacts
 RUN set -e ;\
-    if [ "$PACK" = "1" ]; then make -C opt pack; fi
+    if [ "$PACK" = "1" ]; then bash -l -c "make -C opt pack"; fi
 
 RUN set -e ;\
     if [ "$TEST" = "1" ]; then \
-        TEST= make -C opt test $BUILD_ARGS NO_LFS=1 ;\
+        bash -l -c "TEST= make -C opt test $BUILD_ARGS NO_LFS=1" ;\
         if [[ -d test/logs ]]; then \
             tar -C test/logs -czf bin/artifacts/test-logs-cpu.tgz . ;\
         fi ;\

Dockerfile.gpu

@@ -46,20 +46,18 @@ RUN if [ "$DEPS_ARGS" = "" ]; then ./get_deps.sh gpu; else env $DEPS_ARGS ./get_
 
 ARG BUILD_ARGS=""
 ADD ./ /build
-RUN bash -c "set -e ;\
-    . ./opt/readies/bin/sourced ./profile.d ;\
-    make -C opt build GPU=1 $BUILD_ARGS SHOW=1"
+RUN bash -l -c "make -C opt build GPU=1 $BUILD_ARGS SHOW=1"
 
 ARG PACK
 ARG TEST
 
 RUN mkdir -p bin/artifacts
 RUN set -e ;\
-    if [ "$PACK" = "1" ]; then make -C opt pack GPU=1; fi
+    if [ "$PACK" = "1" ]; then bash -l -c "make -C opt pack GPU=1"; fi
 
 RUN set -e ;\
     if [ "$TEST" = "1" ]; then \
-        TEST= make -C opt test GPU=1 $BUILD_ARGS NO_LFS=1 ;\
+        bash -l -c "TEST= make -C opt test GPU=1 $BUILD_ARGS NO_LFS=1" ;\
         if [[ -d test/logs ]]; then \
             tar -C test/logs -czf bin/artifacts/test-logs-gpu.tgz . ;\
         fi ;\

Dockerfile.gpu-test

@@ -51,15 +51,15 @@ ARG BUILD_ARGS=""
 ADD ./ /build
 RUN set -e ;\
     . venv/bin/activate ;\
-    . ./opt/readies/bin/sourced ./profile.d ;\
-    make -C opt build GPU=1 $BUILD_ARGS SHOW=1
+    bash -l -c "make -C opt build GPU=1 $BUILD_ARGS SHOW=1"
 
 ARG PACK
 
 RUN set -e ;\
 	if [[ $PACK == 1 ]]; then \
 		. venv/bin/activate ;\
 		make -C opt pack GPU=1 VERBOSE=1 ;\
+        bash -l -c "make -C opt pack GPU=1 VERBOSE=1" ;\
 	fi
 
 RUN git remote set-url origin https://github.com/RedisAI/RedisAI

opt/pack.sh

@@ -50,7 +50,8 @@ RAMP_PROG="python3 -m RAMP.ramp"
 BINDIR=$(realpath $BINDIR)
 INSTALL_DIR=$(realpath $INSTALL_DIR)
 
-. $READIES/enable-utf8
+$READIES/enable-utf8
+source /etc/profile.d/utf8.sh
 
 export ARCH=$($READIES/platform --arch)
 export OS=$($READIES/platform --os)

opt/system-setup.py

@@ -7,6 +7,8 @@
 HERE = os.path.abspath(os.path.dirname(__file__))
 ROOT = os.path.abspath(os.path.join(HERE, ".."))
 sys.path.insert(0, os.path.join(HERE, "readies"))
+READIES = os.path.join(ROOT, "opt/readies")
+sys.path.insert(0, READIES)
 import paella
 
 #----------------------------------------------------------------------------------------------
@@ -17,37 +19,30 @@ def __init__(self, nop=False):
 
     def common_first(self):
         self.install_downloaders()
-        self.setup_pip()
-        self.pip_install("wheel virtualenv")
-        # if self.osnick == 'xenial': 
-        #     self.pip_install("setuptools --upgrade")
-        #     self.pip_install("-IU --force-reinstall setuptools")
+        self.pip_install("wheel")
 
-        if self.os == 'linux':
-            self.install("ca-certificates")
-        self.install("git unzip wget patchelf")
-        self.install("coreutils") # for realpath
+        self.install("git unzip patchelf")
+        if self.osnick != 'centos8':
+            self.install("coreutils") # for realpath
 
     def debian_compat(self):
+        self.run("%s/bin/enable-utf8" % READIES)
+        self.run("%s/bin/getgcc" % READIES)
         self.install("gawk")
-        self.install("build-essential cmake")
+        self.install("libssl-dev")
         self.install("python3-regex")
-        self.install("python3-psutil python3-networkx python3-numpy") # python3-skimage
+        self.install("python3-networkx python3-numpy")
+        if self.platform.is_arm():
+            self.install("python3-dev") # python3-skimage
+        self.install("libmpich-dev libopenblas-dev") # for libtorch
         self.install_git_lfs_on_linux()
 
     def redhat_compat(self):
+        self.run("%s/bin/enable-utf8" % READIES)
+        self.run("%s/bin/getepel" % READIES)
         self.install("redhat-lsb-core")
-        self.run("%s/readies/bin/enable-utf8" % HERE)
 
-        self.group_install("'Development Tools'")
-        self.install("cmake3")
-        self.run("ln -sf `command -v cmake3` /usr/local/bin/cmake")
-
-        self.install("centos-release-scl")
-        self.install("devtoolset-8")
-        self.run("cp /opt/rh/devtoolset-8/enable /etc/profile.d/scl-devtoolset-8.sh")
-        paella.mkdir_p("%s/profile.d" % ROOT)
-        self.run("cp /opt/rh/devtoolset-8/enable %s/profile.d/scl-devtoolset-8.sh" % ROOT)
+        self.run("%s/bin/getgcc --modern" % READIES)
 
         self.run("""
             dir=$(mktemp -d /tmp/tar.XXXXXX)
@@ -58,19 +53,15 @@ def redhat_compat(self):
         if not self.dist == "amzn":
             self.install("epel-release")
             self.install("python3-devel libaec-devel")
-            self.install("python36-psutil")
         else:
             self.run("amazon-linux-extras install epel", output_on_error=True)
             self.install("python3-devel")
-            self.pip_install("psutil")
 
         self.install_git_lfs_on_linux()
 
     def fedora(self):
-        self.group_install("'Development Tools'")
-        self.install("cmake")
-        self.run("ln -sf `command -v cmake3` /usr/local/bin/cmake")
-        self.install("python3 python3-psutil python3-networkx")
+        self.run("%s/bin/getepel" % READIES)
+        self.install("python3-networkx")
         self.install_git_lfs_on_linux()
 
     def macosx(self):

tests/qa/RS_VERSIONS

@@ -0,0 +1,4 @@
+6.0.12-41
+5.4.14-37
+6.0.8-30
+100.0.0-2199

tests/qa/nightly.json

@@ -0,0 +1,22 @@
+{
+  "service_id": "single_module_test_cycle",
+  "name": "redisai automation-testing",
+  "properties": {
+    "sut_version": "master",
+    "email_recipients": "redisaidev-aaaacob2o7eeecrhkqwua77kku@redislabs.slack.com",
+    "sut_environments": [],
+    "tools_environment": {},
+    "modules_version": "master",
+    "test_names_modules": [
+        "{{RS_MODULE}}"
+    ],
+    "cycle_environments_setup": [
+      {
+        "teardown": true,
+        "name": "bionic-amd64-aws",
+        "concurrency": 1,
+		"module_url": "http://redismodules.s3.amazonaws.com/{{RS_MODULE_FILE_PREFIX}}/snapshots/{{RS_MODULE_FILE_PREFIX}}-cpu.linux-bionic-x64.master.zip"
+      }
+    ]
+  }
+}

tests/qa/release.json

@@ -0,0 +1,28 @@
+{
+  "service_id": "single_module_test_cycle",
+  "name": "redisai automation-testing",
+  "properties": {
+    "sut_version": "{{RS_VERSION}}",
+    "email_recipients": "redisaidev-aaaacob2o7eeecrhkqwua77kku@redislabs.slack.com",
+    "sut_environments": [],
+    "tools_environment": {},
+    "modules_version": "{{MODULE_VERSION}}",
+    "test_names_modules": [
+        "{{RS_MODULE}}"
+    ],
+    "cycle_environments_setup": [
+      {
+        "teardown": true,
+        "name": "xenial-amd64-aws",
+        "concurrency": 1,
+		"module_url": "http://redismodules.s3.amazonaws.com/{{RS_MODULE_FILE_PREFIX}}/{{RS_MODULE_FILE_PREFIX}}-cpu.linux-xenial-x64.{{MODULE_VERSION}}.zip"
+      },
+      {
+        "teardown": true,
+        "name": "bionic-amd64-aws",
+        "concurrency": 1,
+		"module_url": "http://redismodules.s3.amazonaws.com/{{RS_MODULE_FILE_PREFIX}}/{{RS_MODULE_FILE_PREFIX}}-cpu.linux-bionic-x64.{{MODULE_VERSION}}.zip"
+      }
+    ]
+  }
+}