Skip to content

CircleCI: added QA automation #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 31, 2021
Merged

CircleCI: added QA automation #660

merged 10 commits into from
Mar 31, 2021

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Mar 29, 2021

No description provided.

@rafie rafie requested review from alonre24 and DvirDukhan March 29, 2021 21:21
@rafie rafie requested a review from chayim March 30, 2021 10:41
alonre24
alonre24 reviewed Mar 30, 2021
View reviewed changes
.circleci/config.yml Outdated
@@ -463,7 +495,8 @@ workflows:
<<: *after-linter
- valgrind:
test_args: CLUSTER=0 AOF=0
<<: *on-any-branch
#@@ <<: *on-any-branch
<<: *never
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disabling valgrind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it. I'd argue that we should run valgrind on integration attempts not all branches -IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#@@ is disabling for the sake of the PR, it takes about an hour to run. Re-enabling it once everything passes.
Basically, running valgrind here is Dvir's call, I prefer to either invoke it manually or nightly or when a PR is merged.
We can also try to enable CLang Sanitizers on RedisAI.

@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #660 (86606ed) into master (2cf7050) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 86606ed differs from pull request most recent head ee2b73e. Consider uploading reports for the commit ee2b73e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   78.25%   78.40%   +0.15%     
==========================================
  Files          41       41              
  Lines        6535     6535              
==========================================
+ Hits         5114     5124      +10     
+ Misses       1421     1411      -10
Impacted Files Coverage Δ
src/redis_ai_objects/model.c 78.28% <0.00%> (+1.14%) ⬆️
src/redis_ai_types/script_type.c 70.00% <0.00%> (+5.00%) ⬆️
src/serialization/RDB/encoder/v1/encode_v1.c 89.09% <0.00%> (+10.90%) ⬆️
src/serialization/RDB/encoder/rai_rdb_encode.c 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf7050...ee2b73e. Read the comment docs.

DvirDukhan
DvirDukhan reviewed Mar 30, 2021
View reviewed changes
.circleci/config.yml
@@ -167,7 +167,7 @@ jobs:

build-and-test:
docker:
- image: redisfab/rmbuilder:6.0.9-x64-buster
- image: redisfab/rmbuilder:6.2.1-x64-buster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set the builder image as a parameter? instead of copy-paste?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're working on a config.yml abstraction, but the build logic sets up it's own redis version anyway. I'm considering removing the redis version spec from rmbuilder altogether.

tests/qa/nightly.json
"name": "redisai automation-testing",
"properties": {
"sut_version": "master",
"email_recipients": "redisaidev-aaaacob2o7eeecrhkqwua77kku@redislabs.slack.com",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is our slack channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. You can generate an email address from Slack: https://slack.com/intl/en-il/help/articles/206819278-Send-emails-to-Slack#:~:text=Click%20the%20details%20icon%20in,email%20address%20for%20the%20conversation.

tests/qa/release.json Outdated
"teardown": true,
"name": "rhel7.7-x86_64-aws",
"concurrency": 1,
"module_url": "http://redismodules.s3.amazonaws.com/{{RS_MODULE_FILE_PREFIX}}/{{RS_MODULE_FILE_PREFIX}}-cpu.linux-centos7-x64.{{MODULE_VERSION}}.zip"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I'll disable this one.

@rafie rafie merged commit 5045c12 into master Mar 31, 2021
@rafie rafie deleted the rafi-qa1 branch March 31, 2021 08:32
rafie added a commit that referenced this pull request Mar 31, 2021
@rafie
CircleCI: added QA automation (#660)
e899d47 
(cherry picked from commit 5045c12)
rafie added a commit that referenced this pull request Mar 31, 2021
@rafie
[1.0] CircleCI: added QA automation (#660)
7060702
rafie added a commit that referenced this pull request Apr 18, 2021
@rafie @alonre24
[1.0] CircleCI: added QA automation (#660) (#666)
349bc2f 
* [1.0] CircleCI: added QA automation (#660)
* Updated readies
* Disabled nightly build

Co-authored-by: alonre24 <alonreshef24@gmail.com>
alonre24 pushed a commit that referenced this pull request Apr 18, 2021
@rafie
[1.2] CircleCI: added QA automation (#660) (#665)
e650049 
* CircleCI: added QA automation (#660)

(cherry picked from commit 5045c12)

* CircleCI fixes (#667)

* More CircleCI fixes (#668)

* Updated readies
@chayim chayim mentioned this pull request Jul 22, 2021
Closed
@chayim chayim mentioned this pull request Nov 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonre24 alonre24 alonre24 left review comments

@DvirDukhan DvirDukhan DvirDukhan approved these changes

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafie @chayim @DvirDukhan @alonre24