Skip to content

Conversation

meiravgri
Copy link
Collaborator

revert change from pr #753

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change from PR #753 by modifying the indexCapacity() method in the BruteForceIndex class to return the size of the idToLabelMapping vector instead of its capacity.

  • Changed indexCapacity() to return size() instead of capacity() for the internal vector

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@meiravgri meiravgri added this pull request to the merge queue Sep 15, 2025
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (df0664c) to head (77eb263).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   96.89%   96.86%   -0.03%     
==========================================
  Files         122      122              
  Lines        7533     7533              
==========================================
- Hits         7299     7297       -2     
- Misses        234      236       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit c51cede Sep 15, 2025
21 checks passed
@meiravgri meiravgri deleted the meiravgri-patch-1 branch September 15, 2025 18:38
github-actions bot pushed a commit that referenced this pull request Sep 15, 2025
Copy link

Successfully created backport PR for 8.2:

github-merge-queue bot pushed a commit that referenced this pull request Sep 15, 2025
Change indexCapacity to return size instead of capacity (#778)

(cherry picked from commit c51cede)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants