Skip to content

Deduplicate benchmark downloads and propagate failures #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuyAv46 merged 2 commits into from
Sep 7, 2026
Merged

Deduplicate benchmark downloads and propagate failures #1030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbe64e7
Fix benchmark index download concurrency and error handling
GuyAv46 Sep 6, 2026
46646fc
Retain unlimited parallelism for benchmark downloads
GuyAv46 Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tests/benchmark/bm_files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
BM_TYPE=$1
#!/usr/bin/env bash
set -euo pipefail

# Download each URL once and suppress noisy progress logs.
download_indices() {
cat "$@" | sed '/^[[:space:]]*$/d' | sort -u | \
xargs -r -n 1 -P 0 wget --no-check-certificate --no-verbose \
--timeout=60 --tries=3 --waitretry=5 -P tests/benchmark/data
}

BM_TYPE=${1:-}
alg="hnsw"

if [ -z "$BM_TYPE" ] || [ "$BM_TYPE" = "benchmarks-all" ]; then
cat tests/benchmark/data/hnsw_indices/*.txt tests/benchmark/data/svs_indices/*.txt | xargs -n 1 -P 0 wget --no-check-certificate -P tests/benchmark/data
download_indices tests/benchmark/data/hnsw_indices/*.txt tests/benchmark/data/svs_indices/*.txt
exit 0
elif [ "$BM_TYPE" = "benchmarks-default" ] \
|| [ "$BM_TYPE" = "bm-basics-fp32-single" ] \
Expand Down Expand Up @@ -57,4 +67,4 @@ else
exit 0
fi

cat tests/benchmark/data/${alg}_indices/${alg}_indices_$file_name.txt | xargs -n 1 -P 0 wget --no-check-certificate -P tests/benchmark/data
download_indices "tests/benchmark/data/${alg}_indices/${alg}_indices_$file_name.txt"
Loading