Skip to content

Added support for MODELGET, MODELDEL, SCRIPTGEL, SCRIPTDEL #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 4, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented May 19, 2020

fixes #6, #11, #12, #13, #16
added methods:

  • boolean setTensor(String key, Tensor tensor)
  • boolean setModel(String key, Model model)
  • Model getModel(String key)
  • boolean delModel(String key)
  • boolean setScript(String key, Script script)
  • Script getScript(String key)
  • boolean delScript(String key)

Adds TFLITE, and ONNX backends.
Also extended the coverage and kicked of a more detailed javadoc

@filipecosta90 filipecosta90 added the enhancement New feature or request label May 19, 2020
@filipecosta90 filipecosta90 requested a review from gkorland May 19, 2020 23:31
@filipecosta90 filipecosta90 self-assigned this May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #15 into master will increase coverage by 19.38%.
The diff coverage is 89.32%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage   68.45%   87.83%   +19.38%     
===========================================
  Files           9       11        +2     
  Lines         336      518      +182     
  Branches       44       68       +24     
===========================================
+ Hits          230      455      +225     
+ Misses         86       31       -55     
- Partials       20       32       +12     
Impacted Files Coverage Δ
src/main/java/com/redislabs/redisai/Tensor.java 86.66% <81.81%> (+36.66%) ⬆️
src/main/java/com/redislabs/redisai/RedisAI.java 84.88% <85.33%> (+11.62%) ⬆️
src/main/java/com/redislabs/redisai/Script.java 91.07% <91.07%> (ø)
src/main/java/com/redislabs/redisai/Model.java 92.15% <92.15%> (ø)
src/main/java/com/redislabs/redisai/Backend.java 100.00% <100.00%> (ø)
src/main/java/com/redislabs/redisai/Command.java 100.00% <100.00%> (ø)
src/main/java/com/redislabs/redisai/DataType.java 82.92% <100.00%> (+30.92%) ⬆️
src/main/java/com/redislabs/redisai/Keyword.java 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c110c...2fdbad9. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request introduces 2 alerts when merging f068d7a into cda15c0 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

@filipecosta90
Copy link
Collaborator Author

@dengliming can you review the changes? WDYT of the additions?

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request introduces 2 alerts when merging b091594 into cda15c0 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

@dengliming
Copy link
Contributor

@dengliming can you review the changes? WDYT of the additions?

LGTM :)

@filipecosta90
Copy link
Collaborator Author

@dengliming can you review the changes? WDYT of the additions?

LGTM :)

thank you =)

@filipecosta90 filipecosta90 requested a review from gkorland May 25, 2020 14:43
@filipecosta90
Copy link
Collaborator Author

filipecosta90 commented May 25, 2020

@gkorland lets revise #18 first, and, if you agree, merge it. Then update this one from master and will automatically remove the formatting changes from this and the following PRs.
Also, with regards to the build failing it is due to the fact the latest redisai:edge image does not contain the already merged reply additions on modelget ( it should be a matter of hours for it to be propagated ).

@filipecosta90 filipecosta90 requested a review from gkorland May 27, 2020 13:12
@filipecosta90 filipecosta90 requested a review from gkorland June 2, 2020 22:15
@filipecosta90 filipecosta90 merged commit 90c8731 into master Jun 4, 2020
@filipecosta90 filipecosta90 deleted the extending.model.script.commands branch June 4, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for AI.SCRIPTDEL support for AI.SCRIPTGET support for AI.MODELDEL support for AI.MODELGET
3 participants