-
Notifications
You must be signed in to change notification settings - Fork 4
Added support for MODELGET, MODELDEL, SCRIPTGEL, SCRIPTDEL #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
===========================================
+ Coverage 68.45% 87.83% +19.38%
===========================================
Files 9 11 +2
Lines 336 518 +182
Branches 44 68 +24
===========================================
+ Hits 230 455 +225
+ Misses 86 31 -55
- Partials 20 32 +12
Continue to review full report at Codecov.
|
This pull request introduces 2 alerts when merging f068d7a into cda15c0 - view on LGTM.com new alerts:
|
…RedisAI/JRedisAI into extending.model.script.commands
@dengliming can you review the changes? WDYT of the additions? |
This pull request introduces 2 alerts when merging b091594 into cda15c0 - view on LGTM.com new alerts:
|
…on Model and Script.
LGTM :) |
thank you =) |
…ODELGET. [fix] fixes per PR review
@gkorland lets revise #18 first, and, if you agree, merge it. Then update this one from master and will automatically remove the formatting changes from this and the following PRs. |
…ontaining the script. ensuring same behaviour across different command method wrappers for the same redisai command
… not contain all elements. Added negative testing for resp parsing
fixes #6, #11, #12, #13, #16
added methods:
boolean setTensor(String key, Tensor tensor)
boolean setModel(String key, Model model)
Model getModel(String key)
boolean delModel(String key)
boolean setScript(String key, Script script)
Script getScript(String key)
boolean delScript(String key)
Adds TFLITE, and ONNX backends.
Also extended the coverage and kicked of a more detailed javadoc