add index del_document and extended create_field #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
changed the title
gavrie
suggested changes
Mar 10, 2020
gavrie
suggested changes
May 13, 2020
src/index.rs
Outdated
| @@ -38,7 +44,7 @@ impl Index { | |||
| Self { inner: index } | |||
| } | |||
|
|
|||
| pub fn create_field(&self, name: &str) -> Field { | |||
| pub fn create_field(&self, name: &str, weight: f64, tag_options: Option<&TagOptions>) -> Field { | |||
There was a problem hiding this comment.
- I wouldn't make the
tag_optionsargument optional, but rather always pass an actualTagOptions.
Make use of theDefaulttrait to create this argument if it doesn't need to be customized (see https://doc.rust-lang.org/1.43.0/std/default/trait.Default.html). - While you're at it, I would put the name and weight inside the struct as well so the call site is self-explanatory.
There was a problem hiding this comment.
- Agree
- It's not a pattern we use across the API, the TagOptions are really options while name can't have default value
There was a problem hiding this comment.
Agreed regarding name, but weight is optional; why force the user to specify it when the RS API doesn't require that?
There was a problem hiding this comment.
Weight is not optional by the RediSearch API
gavrie
reviewed
May 18, 2020
src/index.rs
Outdated
| @@ -38,7 +44,7 @@ impl Index { | |||
| Self { inner: index } | |||
| } | |||
|
|
|||
| pub fn create_field(&self, name: &str) -> Field { | |||
| pub fn create_field(&self, name: &str, weight: f64, tag_options: Option<&TagOptions>) -> Field { | |||
There was a problem hiding this comment.
Agreed regarding name, but weight is optional; why force the user to specify it when the RS API doesn't require that?
gavrie
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.