feat(api): add automatic retry with backoff for Figma API rate limiting #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle HTTP 429 responses with Retry-After header - Implement exponential backoff for request timeouts - Exit gracefully when Retry-After exceeds 5 minutes - Add RetryConfiguration for customizable retry behavior - Update all loaders to use requestWithRetry() - Add FigmaAPITests for rate limiting functionality
subdan
reviewed
Dec 26, 2025
| } | ||
|
|
||
| logger.warning("Rate limited by Figma API. Waiting \(Int(retryAfter))s before retry \(attempt + 1)/\(configuration.maxRetries)") | ||
| Thread.sleep(forTimeInterval: retryAfter) |
Collaborator
There was a problem hiding this comment.
It's a bad practice to use Thread.sleep. It blocks the thread. Try to use Timer or DispatchQueue+asyncAfter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic retry with exponential backoff for Figma API rate limiting.
Context: As of November 17, 2025, Figma has updated their API rate limits. See the official announcement and rate limits documentation.
This PR handles:
Retry-AfterheaderRetry-Afterexceeds 5 minutes (avoids indefinite waiting)Changes
RateLimitErrorenum for rate limiting error typesRetryConfigurationstruct for customizable retry behaviorHTTPURLResponseextension to extractRetry-AfterheaderrequestWithRetry()method toClientprotocol andBaseClientFigmaClientto support retry configurationrequestWithRetry()FigmaAPITeststest target with rate limiting testsDefault Configuration
Test Plan