Merged
Conversation
Using standard python enums requires referencing name/value attribute directly, which aenum.Constant made a bit easier. I'd rather not have the dependency, and update callers to use PFIcon.icons new enums.
|
Can't really ACK on this repo, but the change looks sane to me |
quarckster
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using standard python enums requires referencing name/value attribute
directly, which aenum.Constant made a bit easier.
I'd rather not have the dependency, and update callers to use
PFIcon.icons new enums.
Downstream dependency wise, airgun isn't using PFIcon directly, and neither is insights-qe.