Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #43 pylero-cmd to handle run id with spaces, cmd.py #44

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Issue #43 pylero-cmd to handle run id with spaces, cmd.py #44

merged 1 commit into from
Dec 2, 2021

Conversation

sbertramrh
Copy link
Contributor

@sbertramrh sbertramrh commented Dec 2, 2021

Added quotes to allow TestRun.search() to correctly process the string for test run id when it contains spaces.
Fixes: #43

@leelavg
Copy link
Collaborator

leelavg commented Dec 2, 2021

@sbertramrh

  • can you please perform these pre-commit tasks?

@sbertramrh
Copy link
Contributor Author

@sbertramrh

  • can you please perform these pre-commit tasks?

Done. @leelavg Do i need to close and redo the PR? Sorry new to this. thanks.

Results of running the pre-commit:

$ pre-commit run -a
Reorder python imports...................................................Passed
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Debug Statements (Python)................................................Passed
flake8...................................................................Passed
[sbertram@sbertram cli]$ autopep8 --in-place cmd.py
[sbertram@sbertram cli]$

@leelavg
Copy link
Collaborator

leelavg commented Dec 2, 2021

@sbertramrh ack.

  • no need to redo
  • git add src/pylero/cli/cmd.py && git commit --amend --no-edit && git push -f

Added quotes to allow TestRun.search() to correctly process the string for test run id when it contains spaces.
#43
@leelavg leelavg merged commit 920821c into RedHatQE:master Dec 2, 2021
@sbertramrh
Copy link
Contributor Author

Ty @leelavg

@leelavg
Copy link
Collaborator

leelavg commented Dec 2, 2021

Welcome and thanks for raising the issue and sending fix as well 😀

waynesun09 pushed a commit that referenced this pull request Jan 13, 2022
Added quotes to allow TestRun.search() to correctly process the string for test run id when it contains spaces.
Fixes: #43
@sbertramrh sbertramrh deleted the master branch January 26, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylero-cmd, when updating test run, unable to handle run ids with spaces.
2 participants