Repository navigation
Conversation
|
/build-and-push-container |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mijankow
changed the title
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
📌 Additional InformationCustom Commands:
For more information, please refer to the project documentation or contact the maintainers. |
mijankow
changed the title
|
/wip |
openshift-virtualization-qe-bot-2
changed the title
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-6607 published |
1 similar comment
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-6607 published |
2a0f8fd to
867bf7b
Compare
|
@mijankow pls add Signed-off-by: , DCo fails for that |
|
/wip cancel |
openshift-virtualization-qe-bot-6
changed the title
Use full pre-edit spec.source via user_backups so teardown restore does not omit namespace after reconcile, avoiding API 422 on opt-out update tests. Signed-off-by: Michal Jankowski <mijankow@redhat.com>
867bf7b to
f7a40d9
Compare
mijankow
changed the title
|
Clean rebase detected — no code changes compared to previous head ( |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr diff 6607 --repo RedHatQE/openshift-virtualization-tests
printf '\n--- PR HEAD ---\n'
gh pr view 6607 --repo RedHatQE/openshift-virtualization-tests --json headRefOid,baseRefName,files
printf '\n--- LOCAL HEAD ---\n'
git rev-parse HEAD
printf '\n--- SMOKE FILES ---\n'
rg -l '@pytest.mark.smoke' tests/ || true
printf '\n--- GATING FILES ---\n'
rg -l '@pytest.mark.gating' tests/ || trueLength of output: 7355 🏁 Script executed: #!/bin/bash
set -euo pipefail
file=tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py
ast-grep outline "$file" --items all
printf '\n--- CHANGED HELPER REFERENCES ---\n'
rg -n -C4 '\bupdate_data_source\b|TestDataSourcesOptOutLabel' --type py .
printf '\n--- FILE CONTENT ---\n'
sed -n '1,440p' "$file"
printf '\n--- PARENT CONFTEST FILES ---\n'
for dir in . tests tests/infrastructure tests/infrastructure/golden_images tests/infrastructure/golden_images/update_boot_source; do
if [ -f "$dir/conftest.py" ]; then
ast-grep outline "$dir/conftest.py" --items all
fi
done
printf '\n--- MARKER CONFIG FILES ---\n'
fd -i '^(pytest\.ini|pyproject\.toml|setup\.cfg|tox\.ini)$'Length of output: 51455 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n--- REMAINING TESTS ---\n'
sed -n '430,710p' tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py
printf '\n--- FIXTURE CONSUMERS ---\n'
rg -n -C2 '\b(updated_opted_in_data_source_scope_function|updated_opted_out_data_source_scope_function|updated_data_source_with_existing_pvc_scope_function)\b' --type py .
printf '\n--- LOCAL CONFTEST ---\n'
sed -n '1,135p' tests/infrastructure/golden_images/update_boot_source/conftest.py
sed -n '1,55p' tests/infrastructure/golden_images/conftest.py
printf '\n--- MARKER HOOKS ---\n'
sed -n '63,88p' conftest.py
sed -n '340,430p' conftest.py
sed -n '463,528p' conftest.py
printf '\n--- PYTEST CONFIG ---\n'
cat pytest.ini
printf '\n--- DOCUMENTED RUN OPTIONS ---\n'
rg -n -C2 'pytest |test-config|tc-file|--tc|--post-upgrade' README.md tox.ini conftest.py | head -150Length of output: 41345
Test Execution Plan
Affected tests to runAll listed tests have the
The standalone tests reach Include each class's dependency prerequisite:
Both classes use the configured Real tests — cluster requiredUse the cluster's normal kubeconfig and test configuration. Run serially because these tests modify shared golden-image resources. Error path — CNV-98159: pytest tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::TestDataSourcesOptOutLabel \
-k 'test_remove_data_source_dic_label_when_pvc_exists or test_opt_out_label_data_source_reconciles_after_update_with_existing_pvc'Expected: Both tests pass, including teardown. Restore includes the original source namespace and produces no API 422 error. Happy path — opt-in and feature-gate-disabled regression: pytest \
tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::test_opt_in_data_source_reconciles_after_update \
tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::test_opt_out_data_source_reconciles_after_update \
tests/infrastructure/golden_images/update_boot_source/test_ssp_data_sources.py::TestDataSourcesOptInLabel \
-k 'reconciles_after_update or test_opt_in_label_data_source_when_pvc_exists'Expected: All four selected tests pass, including teardown. Confirm that restore retains the original source name and namespace. Where supported, repeat with PVC-backed and snapshot-backed sources to cover both helper branches. Cluster execution was not performed in this environment. You are interacting with an AI system. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-6607 published |
This branch has not been deployed
7 participants
Summary
TestDataSourcesOptOutLabelwhenResourceEditorrestores a partial DataSource backup withoutspec.source.pvc.namespace(CNV-98159).spec.sourceviauser_backupsand wait for reconcile before restore.Test plan
TestDataSourcesOptOutLabelonssp-mje418-upg(CNV 4.18.49) — 4 passedopenshift-virtualization-tests:pr-6607