[4.21] [CCLM] Verify VM boot_id, add post-CCLM validation tests (#4108)#4240
Open
jpeimer wants to merge 1 commit intoRedHatQE:cnv-4.21from
Open
[4.21] [CCLM] Verify VM boot_id, add post-CCLM validation tests (#4108)#4240jpeimer wants to merge 1 commit intoRedHatQE:cnv-4.21from
jpeimer wants to merge 1 commit intoRedHatQE:cnv-4.21from
Conversation
- Check VM boot_id before and after CCLM - Allow connection to the VM Console in the remote cluster with the kubeconfig - Add post-CCLM validation tests Jira: https://issues.redhat.com/browse/CNV-60016 Split from RedHatQE#3926 Assisted by Claude AI and Cursor AI <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Tests** * Expanded cross-cluster VM migration test coverage with additional VM scenarios and state verification. * Added post-migration validation for VM boot integrity and file persistence. * New tests for VM state transitions and cleanup operations. * **Refactor** * Consolidated test constants for broader reusability across test modules. * Refactored VM file verification utilities for improved test modularity. * Enhanced console utility support for remote cluster operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
jpeimer
changed the title
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-5
requested review from
Ahmad-Hafe,
RoniKishner,
dshchedr,
duyanyan,
geetikakay,
josemacassan,
kgoldbla and
kshvaika
Contributor
Author
|
/build-and-push-container |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4240 published |
Contributor
Author
|
/verified
openshift-virtualization-tests-runner/4714/ |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 4436 🏁 Script executed: Length of output: 3033 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #4108
Jira: https://issues.redhat.com/browse/CNV-60016
Assisted by Claude AI and Cursor AI
Tests
Expanded cross-cluster VM migration test coverage with additional VM scenarios and state verification.
Added post-migration validation for VM boot integrity and file persistence.
Refactor
Consolidated test constants for broader reusability across test modules.
Refactored VM file verification utilities for improved test modularity.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: