Skip to content

CherryPicked: [cnv-4.21] [Storage] replace artifactory with DataSource in restricted namespace cloning tests#4173

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 2 commits intocnv-4.21from
CherryPicked-use_quay_in_restricted_namespace_cloning_tests-KpTha
Open

CherryPicked: [cnv-4.21] [Storage] replace artifactory with DataSource in restricted namespace cloning tests#4173
cnv-tests-github-webhook-dollierp[bot] wants to merge 2 commits intocnv-4.21from
CherryPicked-use_quay_in_restricted_namespace_cloning_tests-KpTha

Conversation

@cnv-tests-github-webhook-dollierp

Cherry-pick from main branch, original PR: #3892, PR owner: kshvaika

… cloning tests (#3892)

##### Short description:
This PR replaces the use of the artifactory Cirros image with the
DataSource Fedora in tests/storage/restricted_namespace_cloning
https://issues.redhat.com/browse/CNV-79291

##### More details:

##### What this PR does / why we need it:

##### Which issue(s) this PR fixes:

##### Special notes for reviewer:
The PR was assisted by Cursor AI

##### jira-ticket:
<!-- full-ticket-url needs to be provided. This would add a link to the
pull request to the jira and close it when the pull request is merged
If the task is not tracked by a Jira ticket, just write "NONE".
-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Updated test infrastructure for improved namespace cloning and
multi-storage scenarios.
* Standardized VM and data volume defaults to Fedora images/sizes for
consistent VM testing.
* Added permission-driven test setup to validate restricted VM access
and get-only permissions.
* Cleaned up test parameters and wiring for clearer, more maintainable
storage and cloning tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@openshift-virtualization-qe-bot

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • jpeimer

Reviewers:

  • Ahmad-Hafe
  • dalia-frank
  • duyanyan
  • josemacassan
  • jpeimer
  • kgoldbla
  • kshvaika
  • stesrn
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@kshvaika
Copy link
Contributor

/build-and-push-container

@openshift-virtualization-qe-bot-4

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4173 published

@jpeimer
Copy link
Contributor

jpeimer commented Mar 19, 2026

/approve
/lgtm

@kshvaika
Copy link
Contributor

/verified
openshift-virtualization-tests-runner/4695/
-s -o log_cli=true -m tier2 --jira --skip-deprecated-api-test -rsx tests/storage/restricted_namespace_cloning/ --storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization,hostpath-csi-pvc-block

@josemacassan
Copy link
Contributor

/lgtm

@duyanyan
Copy link
Contributor

/lgtm

@dalia-frank
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants