Manual cherry-pick 4.20: net: Remove fixed IPv4 addresses (#2449)

[azhivovk]

Manual cherry-pick 4.20: net: #2449

cmd log:

git cherry-pick 3c10183673d900b801e1af68b1403129971a8388
Auto-merging tests/network/localnet/conftest.py
Auto-merging tests/network/user_defined_network/test_user_defined_network.py
[remove_hardcoded_ip_prefix_cnv_4.20 1faf569]  net: Remove fixed IPv4 addresses (#2449)
 Author: Asia Zhivov Khromov <azhivovk@redhat.com>
 Date: Thu Nov 6 13:30:49 2025 +0200
 8 files changed, 37 insertions(+), 15 deletions(-)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[azhivovk]

/verified
The manual cherry-pick was auto-merged (see in PR description), no need for verification

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, or conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• EdDev

Reviewers:

• Anatw
• EdDev
• azhivovk
• servolkov
• yossisegev

Available Labels

• hold
• verified
• wip
• lgtm
• approve
• automerge

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will create a change request comment on the 1st line of the 1st file in the pr with the test execution plan.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file
2. Identify affected code paths, functions, and classes
3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
4. Trace test dependencies through imports, shared utilities, and fixture inheritance
5. Detect new tests introduced in the PR

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

• Include only tests directly affected by the changes
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name if only specific tests are needed
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal
• Do not add a follow-up comment in the PR, only the change request one

[coderabbitai]

Test Execution Plan

This PR removes hardcoded IPv4 addresses and replaces them with dynamically generated addresses. The following tests need verification:

Network Bond Tests

• tests/network/bond/test_l2_bridge_over_bond.py::TestBondConnectivity::test_bond

General Network Tests

• tests/network/general/test_cnv_tuning_regression.py::test_vm_cnv_tuning_regression

Jumbo Frame Tests

• tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_connectivity_over_linux_bond_large_mtu
• tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_negative_mtu_linux_bond
• tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_connectivity_over_linux_bridge_large_mtu
• tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_negative_mtu_linux_bridge
• tests/network/jumbo_frame/test_pod_network_ovn.py::TestJumboConnectivity

Localnet Tests

• tests/network/localnet/test_default_bridge.py
• tests/network/localnet/test_ovs_bridge.py

SR-IOV Tests

• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_custom_mtu_connectivity
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity_vlan
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_no_connectivity_no_vlan_to_vlan
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_interfaces_post_reboot
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_migration

User Defined Network Tests

• tests/network/user_defined_network/test_user_defined_network.py::TestUserDefinedNetworkWithVM

Rationale: All modified fixtures and utility functions that configure VM network interfaces with IPv4 addresses now use random_ipv4_address() instead of hardcoded addresses. These tests verify network connectivity, MTU settings, migrations, and IP assignment functionality.

[coderabbitai]

Test Execution Plan

This PR removes hardcoded IPv4 addresses and replaces them with dynamically generated addresses. The following tests need verification:

Network Bond Tests

• tests/network/bond/test_l2_bridge_over_bond.py::TestBondConnectivity::test_bond

General Network Tests

• tests/network/general/test_cnv_tuning_regression.py::test_vm_cnv_tuning_regression

Jumbo Frame Tests

• tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_connectivity_over_linux_bond_large_mtu
• tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_negative_mtu_linux_bond
• tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_connectivity_over_linux_bridge_large_mtu
• tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_negative_mtu_linux_bridge
• tests/network/jumbo_frame/test_pod_network_ovn.py::TestJumboConnectivity

Localnet Tests

• tests/network/localnet/test_default_bridge.py
• tests/network/localnet/test_ovs_bridge.py

SR-IOV Tests

• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_custom_mtu_connectivity
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity_vlan
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_no_connectivity_no_vlan_to_vlan
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_interfaces_post_reboot
• tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_migration

User Defined Network Tests

• tests/network/user_defined_network/test_user_defined_network.py::TestUserDefinedNetworkWithVM

Rationale: All modified fixtures and utility functions that configure VM network interfaces with IPv4 addresses now use random_ipv4_address() instead of hardcoded addresses. These tests verify network connectivity, MTU settings, migrations, and IP assignment functionality.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the list of changed files and their diffs in PR #2903
gh pr view 2903 --json files --jq '.files[] | .path' > /tmp/changed_files.txt
cat /tmp/changed_files.txt

echo "---SEPARATOR---"

# Get the diff for the PR
gh pr diff 2903

Length of output: 10841

---

🏁 Script executed:

#!/bin/bash
# Find tests that use the modified fixtures in each file

echo "=== Tests in test_l2_bridge_over_bond.py ==="
grep -n "^def test_\|^    def test_" tests/network/bond/test_l2_bridge_over_bond.py | head -20

echo -e "\n=== Tests in test_cnv_tuning_regression.py ==="
grep -n "^def test_\|^    def test_" tests/network/general/test_cnv_tuning_regression.py | head -20

echo -e "\n=== Tests in test_bond.py (jumbo_frame) ==="
grep -n "^def test_\|^    def test_" tests/network/jumbo_frame/test_bond.py | head -20

echo -e "\n=== Tests in test_bridge.py (jumbo_frame) ==="
grep -n "^def test_\|^    def test_" tests/network/jumbo_frame/test_bridge.py | head -20

echo -e "\n=== Tests in test_user_defined_network.py ==="
grep -n "^def test_\|^    def test_" tests/network/user_defined_network/test_user_defined_network.py | head -20

echo -e "\n=== Tests that use localnet fixtures (from conftest) ==="
rg -n "ipv4_localnet_address_pool" tests/network/localnet/ --type=py | grep -v "^tests/network/localnet/conftest.py" | head -20

echo -e "\n=== Tests that use sriov fixtures (from conftest) ==="
rg -n "sriov_vm[1-4]|sriov_vm_migrate" tests/network/sriov/ --type=py | grep -v "^tests/network/sriov/conftest.py" | head -30

Length of output: 2999

---

🏁 Script executed:

#!/bin/bash
# Check usage of cloud_init_data_for_secondary_traffic and ipv4_localnet_address_pool

echo "=== Usage of cloud_init_data_for_secondary_traffic ==="
rg -n "cloud_init_data_for_secondary_traffic" tests/network/jumbo_frame/ --type=py

echo -e "\n=== All tests in localnet directory ==="
fd -e py . tests/network/localnet/ -x basename {} | grep "^test_"

echo -e "\n=== Checking for test files that use localnet fixtures ==="
fd "test_.*\.py$" tests/network/localnet/ -x cat {} | grep -l "def test_" | head -10

echo -e "\n=== List all test files in localnet ==="
fd "test_.*\.py$" tests/network/localnet/

echo -e "\n=== SRIOV test names ==="
grep -n "^def test_\|^    def test_" tests/network/sriov/test_sriov.py

echo -e "\n=== Check TestUserDefinedNetworkWithVM class structure ==="
ast-grep --pattern 'class TestUserDefinedNetworkWithVM {
  $$$
}' tests/network/user_defined_network/test_user_defined_network.py

Length of output: 1135

---

🏁 Script executed:

#!/bin/bash
# Check localnet tests and jumbo_frame conftest fixtures

echo "=== Tests in test_default_bridge.py (localnet) ==="
grep -n "^def test_\|^class Test" tests/network/localnet/test_default_bridge.py | head -20

echo -e "\n=== Tests in test_ovs_bridge.py (localnet) ==="
grep -n "^def test_\|^class Test" tests/network/localnet/test_ovs_bridge.py | head -20

echo -e "\n=== Check which fixtures in jumbo_frame/conftest.py use cloud_init_data_for_secondary_traffic ==="
grep -B5 "cloud_init_data_for_secondary_traffic" tests/network/jumbo_frame/conftest.py | grep "^def " | head -10

echo -e "\n=== Tests that use vm_with_primary_nad_vlan fixture ==="
rg -n "vm_with_primary_nad_vlan" tests/network/jumbo_frame/ --type=py | grep -v conftest | head -10

echo -e "\n=== Tests that use vm_with_secondary_nad_vlan fixture ==="
rg -n "vm_with_secondary_nad_vlan" tests/network/jumbo_frame/ --type=py | grep -v conftest | head -10

echo -e "\n=== All fixtures in jumbo_frame conftest ==="
grep "^def .*(" tests/network/jumbo_frame/conftest.py | head -20

Length of output: 1146

---

🏁 Script executed:

#!/bin/bash
# Find tests that use the jumbo_frame conftest fixtures that depend on cloud_init_data_for_secondary_traffic

echo "=== Tests using running_vmd_jumbo_primary_interface_and_secondary_interface ==="
rg -n "running_vmd_jumbo_primary_interface_and_secondary_interface" tests/network/jumbo_frame/ --type=py | grep -v conftest

echo -e "\n=== Tests using running_vme_jumbo_primary_interface_and_secondary_interface ==="
rg -n "running_vme_jumbo_primary_interface_and_secondary_interface" tests/network/jumbo_frame/ --type=py | grep -v conftest

echo -e "\n=== All test files in jumbo_frame directory ==="
fd "test_.*\.py$" tests/network/jumbo_frame/

echo -e "\n=== Tests in test_vlan.py (jumbo_frame) if it exists ==="
if [ -f tests/network/jumbo_frame/test_vlan.py ]; then
    grep -n "^def test_\|^    def test_" tests/network/jumbo_frame/test_vlan.py
else
    echo "File does not exist"
fi

echo -e "\n=== Check all tests that might use ping_over_secondary fixture ==="
rg -n "ping_over_secondary" tests/network/jumbo_frame/ --type=py | grep -v conftest

Length of output: 1088

---

🏁 Script executed:

#!/bin/bash
# Get the complete test names from test_pod_network_ovn.py

echo "=== Tests in test_pod_network_ovn.py (jumbo_frame) ==="
grep -n "^def test_\|^    def test_" tests/network/jumbo_frame/test_pod_network_ovn.py

echo -e "\n=== Check if test_bond is inside a class ==="
grep -B5 "def test_bond" tests/network/bond/test_l2_bridge_over_bond.py | grep "^class"

Length of output: 407

---

🏁 Script executed:

#!/bin/bash
# Create a review comment with the test execution plan on the first file

gh pr review 2903 --comment --body "## Test Execution Plan

This PR removes hardcoded IPv4 addresses and replaces them with dynamically generated addresses. The following tests need verification:

### Network Bond Tests
- \`tests/network/bond/test_l2_bridge_over_bond.py::TestBondConnectivity::test_bond\`

### General Network Tests
- \`tests/network/general/test_cnv_tuning_regression.py::test_vm_cnv_tuning_regression\`

### Jumbo Frame Tests
- \`tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_connectivity_over_linux_bond_large_mtu\`
- \`tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_negative_mtu_linux_bond\`
- \`tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_connectivity_over_linux_bridge_large_mtu\`
- \`tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_negative_mtu_linux_bridge\`
- \`tests/network/jumbo_frame/test_pod_network_ovn.py::TestJumboConnectivity\`

### Localnet Tests
- \`tests/network/localnet/test_default_bridge.py\`
- \`tests/network/localnet/test_ovs_bridge.py\`

### SR-IOV Tests
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity\`
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_custom_mtu_connectivity\`
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity_vlan\`
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_no_connectivity_no_vlan_to_vlan\`
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_interfaces_post_reboot\`
- \`tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_migration\`

### User Defined Network Tests
- \`tests/network/user_defined_network/test_user_defined_network.py::TestUserDefinedNetworkWithVM\`

**Rationale**: All modified fixtures and utility functions that configure VM network interfaces with IPv4 addresses now use \`random_ipv4_address()\` instead of hardcoded addresses. These tests verify network connectivity, MTU settings, migrations, and IP assignment functionality."

Length of output: 0

---

🏁 Script executed:

#!/bin/bash
# Verify the comment was posted by checking recent comments on the PR
gh pr view 2903 --json comments --jq '.comments[-1] | {author: .author.login, body: .body[0:200]}'

Length of output: 290

---

🏁 Script executed:

#!/bin/bash
# Post a review comment on the first line of the first file
# The first file in the PR is tests/network/bond/test_l2_bridge_over_bond.py

cat > /tmp/review_comment.txt << 'EOF'
## Test Execution Plan

This PR removes hardcoded IPv4 addresses and replaces them with dynamically generated addresses. The following tests need verification:

### Network Bond Tests
- `tests/network/bond/test_l2_bridge_over_bond.py::TestBondConnectivity::test_bond`

### General Network Tests
- `tests/network/general/test_cnv_tuning_regression.py::test_vm_cnv_tuning_regression`

### Jumbo Frame Tests
- `tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_connectivity_over_linux_bond_large_mtu`
- `tests/network/jumbo_frame/test_bond.py::TestJumboConnectivity::test_negative_mtu_linux_bond`
- `tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_connectivity_over_linux_bridge_large_mtu`
- `tests/network/jumbo_frame/test_bridge.py::TestJumboConnectivity::test_negative_mtu_linux_bridge`
- `tests/network/jumbo_frame/test_pod_network_ovn.py::TestJumboConnectivity`

### Localnet Tests
- `tests/network/localnet/test_default_bridge.py`
- `tests/network/localnet/test_ovs_bridge.py`

### SR-IOV Tests
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity`
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_custom_mtu_connectivity`
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_basic_connectivity_vlan`
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_no_connectivity_no_vlan_to_vlan`
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_interfaces_post_reboot`
- `tests/network/sriov/test_sriov.py::TestSRIOVConnectivity::test_sriov_migration`

### User Defined Network Tests
- `tests/network/user_defined_network/test_user_defined_network.py::TestUserDefinedNetworkWithVM`

**Rationale**: All modified fixtures and utility functions that configure VM network interfaces with IPv4 addresses now use `random_ipv4_address()` instead of hardcoded addresses. These tests verify network connectivity, MTU settings, migrations, and IP assignment functionality.
EOF

# Get the commit SHA for the PR
COMMIT_SHA=$(gh pr view 2903 --json commits --jq '.commits[-1].oid')

echo "Commit SHA: $COMMIT_SHA"

# Use the GitHub API to create a review comment on line 1 of the first file
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/2903/comments \
  -f body="$(cat /tmp/review_comment.txt)" \
  -f commit_id="$COMMIT_SHA" \
  -f path="tests/network/bond/test_l2_bridge_over_bond.py" \
  -F line=1 \
  -f side="RIGHT"

echo "Review comment posted successfully"

Length of output: 418

---

🏁 Script executed:

#!/bin/bash
# The API requires a line that was changed in the diff. Let's post on line 11 which has the new import
# Get the commit SHA for the PR
COMMIT_SHA=$(gh pr view 2903 --json commits --jq '.commits[-1].oid')

echo "Commit SHA: $COMMIT_SHA"

# Use the GitHub API to create a review comment on a changed line (line 11 - the new import)
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/2903/comments \
  -f body="$(cat /tmp/review_comment.txt)" \
  -f commit_id="$COMMIT_SHA" \
  -f path="tests/network/bond/test_l2_bridge_over_bond.py" \
  -F line=11 \
  -f side="RIGHT" 2>&1

if [ $? -ne 0 ]; then
    echo "Failed to post on line 11, trying line 130"
    # Try line 130 which was modified
    gh api \
      --method POST \
      -H "Accept: application/vnd.github+json" \
      /repos/RedHatQE/openshift-virtualization-tests/pulls/2903/comments \
      -f body="$(cat /tmp/review_comment.txt)" \
      -f commit_id="$COMMIT_SHA" \
      -f path="tests/network/bond/test_l2_bridge_over_bond.py" \
      -F line=130 \
      -f side="RIGHT"
fi

Length of output: 4762

---

@openshift-virtualization-qe-bot-3: I've successfully analyzed all modified files in PR #2903 and created a comprehensive test execution plan. The plan has been posted as a review comment on the first file.

The test execution plan covers:

• Network Bond Tests (1 test)
• General Network Tests (1 test)
• Jumbo Frame Tests (7 tests across 3 test files)
• Localnet Tests (2 full test files)
• SR-IOV Tests (6 tests)
• User Defined Network Tests (1 full test class)

All these tests are affected because this PR replaces hardcoded IPv4 addresses like 10.200.0.1/24 with dynamically generated addresses using the random_ipv4_address() function in fixtures and utility functions that configure VM network interfaces.

---

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

---

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

---

Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 2045
File: tests/virt/cluster/vm_lifecycle/conftest.py:46-47
Timestamp: 2025-09-15T06:49:53.478Z
Learning: In the openshift-virtualization-tests repo, large fixture refactoring efforts like the golden image data source migration are handled incrementally by directory/team ownership. The virt/cluster directory is handled separately from virt/node, tests/infra, tests/storage, etc., with each area managed by relevant teams in follow-up PRs.

---

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/conftest.py:289-297
Timestamp: 2025-08-09T01:52:26.683Z
Learning: When user dshchedr moves working code from one location to another in the openshift-virtualization-tests repository, they prefer not to modify it unless there's a real issue, maintaining the original implementation to avoid introducing unnecessary changes.

---

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR #1904 focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1249-1254
Timestamp: 2025-08-06T13:57:51.928Z
Learning: User rnetser verified that all calls to get_infrastructure() function use the admin_client parameter, confirming that signature changes requiring this parameter don't cause breaking changes in the openshift-virtualization-tests codebase.

---

Learnt from: chandramerla
Repo: RedHatQE/openshift-virtualization-tests PR: 2577
File: tests/virt/node/workload_density/test_free_page_reporting.py:90-90
Timestamp: 2025-11-20T16:27:01.693Z
Learning: The virtio_balloon free page reporting issue on s390x architecture (tracked in OCPBUGS-51113) has been fixed. Free page reporting tests in tests/virt/node/workload_density/test_free_page_reporting.py are now safe to run on s390x clusters.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

---

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.194Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.

---

Learnt from: SiboWang1997
Repo: RedHatQE/openshift-virtualization-tests PR: 1566
File: tests/global_config_x86_64.py:29-29
Timestamp: 2025-07-25T01:59:02.180Z
Learning: In the openshift-virtualization-tests repo, the s390x architecture still relies on Fedora 41 images, while only x86_64 is updated to Fedora 42 in PR #1566.

---

Learnt from: rlobillo
Repo: RedHatQE/openshift-virtualization-tests PR: 1984
File: tests/install_upgrade_operators/network_policy/test_network_policy_components.py:0-0
Timestamp: 2025-09-12T09:39:12.961Z
Learning: IPv6 support is not needed for network policy tests in the openshift-virtualization-tests repository, as tests would fail earlier if the destination IP is IPv6.