Add new resource console_plugin #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!verified |
myakove
requested changes
May 23, 2022
ocp_resources/console_plugin.py
Outdated
| """ | ||
|
|
||
| api_group = Resource.ApiGroup.CONSOLE_OPENSHIFT_IO | ||
| api_version = Resource.ApiVersion.V1ALPHA1 |
There was a problem hiding this comment.
api_version should be set automatically.
There was a problem hiding this comment.
I will remove this.
|
Kudos, SonarCloud Quality Gate passed!
|
|
!verified |
myakove
approved these changes
May 24, 2022
myakove
pushed a commit
to myakove/openshift-python-wrapper
that referenced
this pull request
May 24, 2022
* Add new resource console_plugin * Removed api_version
myakove
added a commit
that referenced
this pull request
May 24, 2022
myakove
added a commit
that referenced
this pull request
May 25, 2022
* update setup.cfg * add .release-it.json config * update .release-it.json config * README - update release process (#539) * readme * Add new resource console_plugin (#551) * Add new resource console_plugin * Removed api_version * ChaosEngine: set constants uppercase (#555) * ChaosEngine: set constants uppercase * ChaosEngine: remove api_version * Add sync-main github action * Add sync-main github action * Add sync-main github action * in-solidarity: add .release-it.json to ignore list * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action Co-authored-by: Meni Yakove <myakove@gmail.com> Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: rnetser <rnetser@redhat.com> Co-authored-by: dbasunag <82394005+dbasunag@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove
added a commit
that referenced
this pull request
May 25, 2022
* update setup.cfg * add .release-it.json config * update .release-it.json config * README - update release process (#539) * readme * Add new resource console_plugin (#551) * Add new resource console_plugin * Removed api_version * ChaosEngine: set constants uppercase (#555) * ChaosEngine: set constants uppercase * ChaosEngine: remove api_version * Add sync-main github action * Add sync-main github action * Add sync-main github action * in-solidarity: add .release-it.json to ignore list * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Release 4.11.12 * Release 4.11.13 * Update README.md Update example * Release 4.11.14 * Release 4.11.15 Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: rnetser <rnetser@redhat.com> Co-authored-by: dbasunag <82394005+dbasunag@users.noreply.github.com>
myakove
added a commit
that referenced
this pull request
May 25, 2022
* update setup.cfg * add .release-it.json config * update .release-it.json config * README - update release process (#539) * readme * Add new resource console_plugin (#551) * Add new resource console_plugin * Removed api_version * ChaosEngine: set constants uppercase (#555) * ChaosEngine: set constants uppercase * ChaosEngine: remove api_version * Add sync-main github action * Add sync-main github action * Add sync-main github action * in-solidarity: add .release-it.json to ignore list * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * Add sync-main github action * update README and setup.cfg Co-authored-by: Meni Yakove <myakove@gmail.com> Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: rnetser <rnetser@redhat.com> Co-authored-by: dbasunag <82394005+dbasunag@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description: Adding new resource console_plugin to interact with ConsolePlugin kind.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: