feat: Update network policy resource

[rlobillo]

Short description:

Update networkPolicy resource following https://github.com/RedHatQE/openshift-python-wrapper/blob/main/class_generator/README.md

More details:

N/A

What this PR does / why we need it:

We need it for RedHatQE/openshift-virtualization-tests#1984

Which issue(s) this PR fixes:

N/A

Special notes for reviewer:

N/A

Bug:

N/A

Summary by CodeRabbit

• New Features

  • NetworkPolicy creation now accepts egress, ingress, pod selector, and policy types, enabling richer policy configuration.
  • Automatically generates a complete spec when converting a NetworkPolicy to a dictionary, including optional fields when provided.

• Bug Fixes

  • Adds validation to prevent creating a NetworkPolicy without a pod selector (when not using an existing manifest), providing clearer error feedback.

• Improvements

  • More consistent metadata typing for NetworkPolicy to improve reliability across usages.

[coderabbitai]

Walkthrough

Adds initializer and serialization logic to the NetworkPolicy resource. Introduces parameterized init, typed api_group attribute, and a to_dict method that validates required pod_selector and conditionally populates spec fields (podSelector, egress, ingress, policyTypes). Updates imports to include MissingRequiredArgumentError and Any.

Changes

Cohort / File(s)	Summary
NetworkPolicy resource updates ocp_resources/network_policy.py	Add init(egress, ingress, pod_selector, policy_types, **kwargs); add typed api_group: str; implement to_dict with validation for pod_selector when no kind_dict/yaml_file; populate spec.podSelector and optional egress/ingress/policyTypes; import MissingRequiredArgumentError and Any.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

branch-main

Suggested reviewers

• rnetser
• myakove

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The pull request description follows the repository’s template exactly, providing values for each required section, even if some are marked “N/A,” and clearly explains the short description, rationale, and related work, so it meets the expected structure.
Title Check	✅ Passed	The title concisely and accurately describes the primary change—updating the NetworkPolicy resource implementation—by referencing the specific component and using a clear conventional commit prefix without extraneous details.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[redhat-qe-bot]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest python-module-install - Test Python package installation
• /retest conventional-title - Validate commit message format
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 0 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, or conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• myakove
• rnetser

Reviewers:

• dbasunag
• myakove
• rnetser

Available Labels

• hold
• verified
• wip
• lgtm
• approve
• automerge

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a48aaa and e6d7608.

📒 Files selected for processing (1)

• ocp_resources/network_policy.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

ocp_resources/network_policy.py (2)

ocp_resources/resource.py (2)

• NamespacedResource (1534-1644)
• ApiGroup (466-576)

ocp_resources/exceptions.py (1)

• MissingRequiredArgumentError (5-10)

🔇 Additional comments (5)

ocp_resources/network_policy.py (5)

1-2: LGTM!

The file includes the standard generated code comment and appropriate spacing.

---

4-6: LGTM!

The imports are correctly added with the necessary types for the implementation.

---

14-14: LGTM!

The API group is correctly set to NETWORKING_K8S_IO with proper type annotation.

---

16-47: LGTM!

The __init__ method is well-structured with appropriate parameter types and comprehensive docstring. The parameter names match the Kubernetes NetworkPolicy spec fields, and the initialization logic correctly stores all provided values.

---

55-68: LGTM!

The spec field population logic correctly maps the instance attributes to the NetworkPolicy specification format. The conditional inclusion of optional fields (egress, ingress, policyTypes) follows the proper pattern of only including fields when they are provided.

[myakove]

/approve

[rnetser]

/lgtm

[rlobillo]

/verified

Updating RedHatQE/openshift-virtualization-tests#1984 to use this PR, the tests passed:

$ cat pyproject.toml | grep wrapper
  "openshift-python-wrapper @ git+https://github.com/rlobillo/openshift-python-wrapper.git@netpol",
$ grep "ocp_resources.network_policy" tests/install_upgrade_operators/network_policy/conftest.py
from ocp_resources.network_policy import NetworkPolicy
$ grep "with NetworkPolicy" -A8 tests/install_upgrade_operators/network_policy/conftest.py 
    with NetworkPolicy(
        name="test-allow-all-traffic",
        namespace=hco_namespace.name,
        client=admin_client,
        pod_selector={"matchLabels": network_policy_match_labels},
        policy_types=["Ingress", "Egress"],
        ingress=[{}],
        egress=[{}],
    ):
--
    with NetworkPolicy(
        name="test-allow-all-traffic",
        namespace=hco_namespace.name,
        client=admin_client,
        pod_selector={"matchLabels": network_policy_match_labels},
        policy_types=["Ingress", "Egress"],
        ingress=[{}],
        egress=[{}],
    ):
$ grep ^TEST ~/rlobillo/pytest.log 
TEST: test_console_plugin_network_policy_blocks_ingress_unauthorized_traffic[kubevirt-console-plugin-np] STATUS: PASSED
TEST: test_apiserver_proxy_network_policy_blocks_egress_unauthorized_traffic[kubevirt-apiserver-proxy-np] STATUS: PASSED