Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set python>=3.9, python 3.8 is EOL #2189

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Set python>=3.9, python 3.8 is EOL #2189

merged 3 commits into from
Nov 5, 2024

Conversation

myakove
Copy link
Collaborator

@myakove myakove commented Oct 30, 2024

Summary by CodeRabbit

  • New Features

    • Updated minimum required Python version from 3.8 to 3.9.
  • Style

    • Enhanced formatting for consistency and readability across various sections of the configuration file.

Copy link

coderabbitai bot commented Oct 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several modifications to the pyproject.toml file, focusing on formatting changes and an update to the minimum required Python version. Key adjustments include the addition of commas for consistency, removal of unnecessary spaces in various sections, and a critical update of the requires-python field from ">=3.8" to ">=3.9". These changes enhance the overall structure and readability of the file while ensuring compatibility with newer Python versions.

Changes

File Change Summary
pyproject.toml - Updated requires-python from ">=3.8" to ">=3.9".
- Reformatted sections for consistency: added commas, removed unnecessary spaces in lists, and improved overall structure.

Possibly related issues

Possibly related PRs

  • Set python>=3.9, python 3.8 is EOL #2189: This PR also updates the requires-python field in the [project] section of pyproject.toml from ">=3.8" to ">=3.9", making it directly related to the main PR's changes regarding the Python version requirement.

Suggested reviewers

  • rnetser
  • dbasunag
  • omrirh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@redhat-qe-bot2
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@myakove
Copy link
Collaborator Author

myakove commented Oct 30, 2024

/verified

1 similar comment
@myakove
Copy link
Collaborator Author

myakove commented Oct 30, 2024

/verified

@rh-bot-1 rh-bot-1 removed the verified label Nov 4, 2024
@myakove
Copy link
Collaborator Author

myakove commented Nov 4, 2024

/verified

@myakove
Copy link
Collaborator Author

myakove commented Nov 5, 2024

/verified

@myakove myakove merged commit 1989968 into main Nov 5, 2024
4 of 6 checks passed
@myakove myakove deleted the python39 branch November 5, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants