Make CVSS4.as_json return valid json and make "minimal" arg work.#76
Open
Make CVSS4.as_json return valid json and make "minimal" arg work.#76
Conversation
Closes issue #74 JSON Schema: https://www.first.org/cvss/cvss-v4.0.json
af15dca to
d686062
Compare
Collaborator
Author
|
The official json schema doesn't check for missing mandatory metrics nor for extraneous invalid metrics. A workaround to manually check the validated json against the schema is to make one value invalid and see that the schema doesn't validate (= it's a metric known to the schema), and do this separately for each metric, thus manually validating that each generated dictionary key / cvss v4 json metric has a valid name. |
Maybe, I'm missing something but wouldn't it be easier to either:
The latter one has the benefit that one can be sure that the JSON is also semantically valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #74
JSON Schema: https://www.first.org/cvss/cvss-v4.0.json