Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update ros-frontend #388

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Red Hat Konflux update ros-frontend #388

merged 4 commits into from
Oct 9, 2024

Conversation

red-hat-konflux[bot]
Copy link
Contributor

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@skateman
Copy link
Member

skateman commented Oct 9, 2024

@PreetiW can you please also add the renovate.json from the PR I gave you? And avoid merging for a little longer please 🙏

@skateman
Copy link
Member

skateman commented Oct 9, 2024

ReleasePlan is in, you can merge the PR if it's green. I also recommend to set the konflux PR check as a requirement on the branch protection rules.

@PreetiW
Copy link
Contributor

PreetiW commented Oct 9, 2024

@PreetiW can you please also add the renovate.json from the PR I gave you? And avoid merging for a little longer please 🙏

@skateman added the renovate.json file, waiting for jobs checks now. I saw the PR you gave and compliance both have commented run-unit-test task and I did the same for ros-frontend. Hope that's okay!

@PreetiW
Copy link
Contributor

PreetiW commented Oct 9, 2024

ReleasePlan is in, you can merge the PR if it's green. I also recommend to set the konflux PR check as a requirement on the branch protection rules.

thank you for the suggestion @skateman we will add it.
@kgaikwad can you please add this rule as I don't have enough access to update the settings for this repo 🙌🏻

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.65%. Comparing base (1284678) to head (0636ff4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   19.65%   19.65%           
=======================================
  Files          45       45           
  Lines         987      987           
  Branches      194      194           
=======================================
  Hits          194      194           
  Misses        741      741           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PreetiW PreetiW merged commit edc64f7 into main Oct 9, 2024
8 checks passed
@kgaikwad
Copy link
Collaborator

kgaikwad commented Oct 9, 2024

I also recommend to set the konflux PR check as a requirement on the branch protection rules.

@skateman - When you mentioned as a requirement, does it mean one should add it as status check for each PR?

@skateman
Copy link
Member

skateman commented Oct 9, 2024

It does, this is how we have it, but you need to search for it in the search field (konflux PR)
image

@kgaikwad
Copy link
Collaborator

kgaikwad commented Oct 9, 2024

Done! I have configured a branch protection rule for konflux PR check in both frontend & backend repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants