-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat Konflux update ros-frontend #388
Conversation
Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
Can one of the admins verify this patch? |
@PreetiW can you please also add the renovate.json from the PR I gave you? And avoid merging for a little longer please 🙏 |
ReleasePlan is in, you can merge the PR if it's green. I also recommend to set the konflux PR check as a requirement on the branch protection rules. |
@skateman added the renovate.json file, waiting for jobs checks now. I saw the PR you gave and compliance both have commented |
thank you for the suggestion @skateman we will add it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 19.65% 19.65%
=======================================
Files 45 45
Lines 987 987
Branches 194 194
=======================================
Hits 194 194
Misses 741 741
Partials 52 52 ☔ View full report in Codecov by Sentry. |
@skateman - When you mentioned as a requirement, does it mean one should add it as status check for each PR? |
Done! I have configured a branch protection rule for konflux PR check in both frontend & backend repositories. |
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization