POL-114 First version of typeahead #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks awesome, I'm eager to give this a try. |
|
I set the DNM because I though this was not yet needed, I'll rebase later today so someone can review and merge if is good enough. |
Currently only showing the facts keys on the typeahead
|
Rebased, anyone wants to take a look? |
|
I had a quick look already, nothing scary. I will merge and can check the feature in CI before we push to prod again. |
theute
approved these changes
Apr 17, 2020
theute
pushed a commit
that referenced
this pull request
Apr 20, 2020
Currently only showing the facts keys on the typeahead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only showing the facts keys on the typeahead