Skip to content

Conversation

@mayurilahane
Copy link
Contributor

@mayurilahane mayurilahane commented Dec 19, 2025

Description

  • Export data into CSV and JSON.
  • Test exporting ability on the "Advisories", "Packages"
    and "Systems" pages.
  • Validate the data structure and some of the contents.
  • Used "papaparse" to parse the CSV files and
    added it to the dependencies.
  • Fixed advisories navigation to use exact matching. -

https://issues.redhat.com/browse/HMS-9725

@mayurilahane
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.53%. Comparing base (1bf4fc5) to head (f00fd24).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1457   +/-   ##
=======================================
  Coverage   62.53%   62.53%           
=======================================
  Files         127      127           
  Lines        3310     3310           
  Branches      899      892    -7     
=======================================
  Hits         2070     2070           
  Misses       1120     1120           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@TenSt TenSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor comments, but otherwise all is good, great job!

@TenSt TenSt self-assigned this Dec 22, 2025
@mayurilahane mayurilahane force-pushed the mlahane/9725 branch 2 times, most recently from 2f0c5e3 to 3b1cd78 Compare January 5, 2026 19:18
@mayurilahane mayurilahane marked this pull request as ready for review January 5, 2026 19:37
@mayurilahane mayurilahane requested a review from a team as a code owner January 5, 2026 19:37
@mayurilahane mayurilahane force-pushed the mlahane/9725 branch 2 times, most recently from 556c02f to d553f7f Compare January 7, 2026 14:29
Copy link
Collaborator

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments with possible improvements 🔧
otherwise, this looks good! ✨ 👏🏼

Copy link
Contributor

@TenSt TenSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurilahane mayurilahane force-pushed the mlahane/9725 branch 3 times, most recently from 088bb43 to 3af6a1a Compare January 8, 2026 18:56
Copy link
Collaborator

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! thanks! ✨
ack! 🚀 ✅

- function to export data into CSV and JSON.
- using system fixture to create a system for
testing.
- Test exporting ability on the "Advisories",
 "Packages" and "Systems" pages.
- Validate the data structure and some of the
contents.
- Used "papaparse" to parse the CSV files
and added it to the dependencies.
- Fixed advisories navigation to use exact
matching.
- Adding wait for table load to the navigation
functions.
@mayurilahane mayurilahane requested a review from a team as a code owner January 9, 2026 19:31
@TenSt TenSt merged commit aa080f7 into RedHatInsights:master Jan 9, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants