-
Notifications
You must be signed in to change notification settings - Fork 51
HMS-9725: Add test to verify exporting feature on patch #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78282dd to
c91275a
Compare
|
/retest |
c91275a to
368483f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
=======================================
Coverage 62.53% 62.53%
=======================================
Files 127 127
Lines 3310 3310
Branches 899 892 -7
=======================================
Hits 2070 2070
Misses 1120 1120
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TenSt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor comments, but otherwise all is good, great job!
2f0c5e3 to
3b1cd78
Compare
556c02f to
d553f7f
Compare
dominikvagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small comments with possible improvements 🔧
otherwise, this looks good! ✨ 👏🏼
TenSt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
088bb43 to
3af6a1a
Compare
dominikvagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! thanks! ✨
ack! 🚀 ✅
- function to export data into CSV and JSON. - using system fixture to create a system for testing. - Test exporting ability on the "Advisories", "Packages" and "Systems" pages. - Validate the data structure and some of the contents. - Used "papaparse" to parse the CSV files and added it to the dependencies. - Fixed advisories navigation to use exact matching. - Adding wait for table load to the navigation functions.
3af6a1a to
f00fd24
Compare
Description
and "Systems" pages.
added it to the dependencies.
https://issues.redhat.com/browse/HMS-9725