Provide extensibility mechanism where additional subreports can be added - #48
Open
mstruk wants to merge 3 commits into
Open
Provide extensibility mechanism where additional subreports can be added#48mstruk wants to merge 3 commits into
mstruk wants to merge 3 commits into
Conversation
Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
ServiceLoader based extension mechanism via `com.redhat.insights.agent.api.SubreportProvider` Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
…cation Main.main() Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API interface
com.redhat.insights.agent.api.SubreportProvideris defined. Implementations of it are discovered at runtime via ServiceLoader pattern.A custom agent project can add a dependency on
insights-java-agentand additionally provide customInsightsSubreportimplementations and make them available viaSubreportProviderimplementation. A custom agent project can use the same packaging strategy asinsights-java-agentto provide a shaded agent archive that also contains the customSubreportProviderimplementations.