Remove insights- repo name #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
remove-insights
branch
from
bd817ee to
40a0e0a
Compare
Hyperkid123
reviewed
Jan 19, 2021
README.md
Outdated
|
|
||
| This file exports an object with the configuration for webpack and webpack dev server. | ||
| We are used [federated modules](https://webpack.js.org/concepts/module-federation/) to seamlessly load multiple application. |
There was a problem hiding this comment.
I wanted to go with We are using and We used and end up with We are used 😄
ryelo
requested changes
Jan 19, 2021
README.md
Outdated
Comment on lines
61
to
63
| ## Insights Components | ||
|
|
||
| Insights Platform will deliver components and static assets through [npm](https://www.npmjs.com/package/@red-hat-insights/insights-frontend-components). ESI tags are used to import the [chroming](https://github.com/RedHatInsights/insights-chrome) which takes care of the header, sidebar, and footer. | ||
| Insights Platform will deliver components and static assets through [npm](https://www.npmjs.com/package/@redhat-cloud-services/frontend-components). ESI tags are used to import the [chroming](https://github.com/RedHatInsights/insights-chrome) which takes care of the header, sidebar, and footer. |
There was a problem hiding this comment.
Can we remove Insights from each of these?
There was a problem hiding this comment.
Good point, I went trough the docs and removed bunch of other insights mentions.
karelhala
force-pushed
the
remove-insights
branch
from
86a8f25 to
3b413a6
Compare
ryelo
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHCLOUD-11596
Remove insights from repo name
Since we don't want to confuse consumers of this repository, we should remove the insights prefix. This goes hand to hand with renaming all the references in this repository.