New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #675

Merged

matoval merged 1 commit into RedHatInsights:master from acosferreira:poc-fix-general-table

May 2, 2023

Collaborator

acosferreira commented May 2, 2023

Description

import props

Fixes # (POC)

Type of change

What is it?

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation update
Tests update

Checklist:

I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I run npm run lint:js:fix to check that my code is properly formatted

fix

ef9661f

acosferreira requested review from resoluteCoder, adeliaferreira, matoval, de1987, acruzgon and tpapaioa as code owners

May 2, 2023 23:21

mergify bot added the new feature label

matoval approved these changes

View reviewed changes

matoval merged commit 9e93124 into RedHatInsights:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

matoval matoval approved these changes

resoluteCoder Awaiting requested review from resoluteCoder

adeliaferreira Awaiting requested review from adeliaferreira

de1987 Awaiting requested review from de1987

acruzgon Awaiting requested review from acruzgon

tpapaioa Awaiting requested review from tpapaioa

Labels