Skip to content

Conversation

@maknop
Copy link
Contributor

@maknop maknop commented Feb 19, 2024

Recent Kafka update has deprecated the type value to just use name.

@maknop maknop requested a review from psav February 19, 2024 16:24
@maknop maknop self-assigned this Feb 19, 2024
@maknop maknop requested a review from adamrdrew February 19, 2024 16:24
maknop and others added 2 commits February 19, 2024 09:35
* Updated Kafka CRDs to latest in strimzi client go
* `name` field was missing
* Fixed a expected/actual flip in a test
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maknop maknop merged commit 5f712e0 into master Feb 19, 2024
@psav psav deleted the mknop/update_kafka_listener_value branch February 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants