[RHCLOUD-30831] - refactor(db): Remove Postgresql 10 support #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victoremepunto
force-pushed
the
remove-postgresql-10-support
branch
from
c1df416 to
0dfb6db
Compare
Victoremepunto
changed the title
psav
requested changes
Feb 7, 2024
Collaborator
psav
left a comment
psav
left a comment
There was a problem hiding this comment.
You also need to find and change this kubebuilder annotation line
// +kubebuilder:validation:Enum:=10;12;13;14;15
psav
added
technical debt
psav
changed the title
Contributor
Author
|
This is waiting on RedHatInsights/config-manager#139 |
Victoremepunto
force-pushed
the
remove-postgresql-10-support
branch
from
5056f53 to
f09a07d
Compare
Contributor
Author
|
/retest |
Victoremepunto
force-pushed
the
remove-postgresql-10-support
branch
2 times, most recently
from
ee44c8a to
d310cc2
Compare
bsquizz
requested changes
Mar 27, 2024
Contributor
bsquizz
left a comment
bsquizz
left a comment
There was a problem hiding this comment.
Still one test referencing version 10:
10:48:23 [2024-03-26T10:48:23.157Z] logger.go:42: 10:48:23 | test-multi-app-interface-db/1-pods | ClowdApp:test-multi-app-interface-db/app-e created
10:48:23 [2024-03-26T10:48:23.157Z] case.go:364: failed in step 1-pods
10:48:23 [2024-03-26T10:48:23.157Z] case.go:366: ClowdApp.cloud.redhat.com "app-default-ca" is invalid: spec.database.version: Unsupported value: 10: supported values: "12", "13", "14", "15", "16"
10:48:23 [2024-03-26T10:48:23.157Z] case.go:366: ClowdApp.cloud.redhat.com "app-b" is invalid: spec.database.version: Unsupported value: 10: supported values: "12", "13", "14", "15", "16"
10:48:23 [2024-03-26T10:48:23.157Z] case.go:366: ClowdApp.cloud.redhat.com "app-c" is invalid: spec.database.version: Unsupported value: 10: supported values: "12", "13", "14", "15", "16"
10:48:23 [2024-03-26T10:48:23.157Z] case.go:366: ClowdApp.cloud.redhat.com "app-d" is invalid: spec.database.version: Unsupported value: 10: supported values: "12", "13", "14", "15", "16"
f3c05ba to
1e513ce
Compare
Contributor
Author
Thanks @bsquizz !! fixed! |
bsquizz
approved these changes
Mar 28, 2024
Contributor
Author
|
I think the Konflux pipeline may be fixed by #965 |
Victoremepunto
force-pushed
the
remove-postgresql-10-support
branch
from
1e513ce to
b4ce304
Compare
psav
force-pushed
the
remove-postgresql-10-support
branch
from
b4ce304 to
66b2900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.