Skip to content

Conversation

@Victoremepunto
Copy link
Contributor

No description provided.

@psav
Copy link
Collaborator

psav commented Feb 5, 2024

looks good to me

psav
psav previously approved these changes Feb 5, 2024
Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a massive fan of moving the database definitions, I know they are used outside of the database provider, but it just feels a little counter intuitive to move them else where. I would perhaps prefer to have a separate KC one track it separately, but I'm fine with this going in and we'll see what happens.

@psav
Copy link
Collaborator

psav commented Feb 5, 2024

This needs a JIRA link

@psav psav added technical debt Technical Debt related pr-functional-change Will result in a new binary labels Feb 5, 2024
@Victoremepunto Victoremepunto changed the title update(db): Bump PostgreSQL images to add HLL support [RHCLOUD-30810] update(db): Bump PostgreSQL images to add HLL support Feb 5, 2024
@Victoremepunto
Copy link
Contributor Author

This needs a JIRA link

Added to the title

@Victoremepunto
Copy link
Contributor Author

I'm not a massive fan of moving the database definitions, I know they are used outside of the database provider, but it just feels a little counter intuitive to move them else where. I would perhaps prefer to have a separate KC one track it separately, but I'm fine with this going in and we'll see what happens.

This was my best attempt at trying to "fix" hardcoded configuration in the code, moving it to a common place, I don't have strong opinions on where to, "provider utils" seemed as good as any other place - I'd love to have some better configuration management so we avoid having config embedded between code

@Victoremepunto
Copy link
Contributor Author

/retest

@adamrdrew adamrdrew merged commit 91f5d3f into RedHatInsights:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-functional-change Will result in a new binary technical debt Technical Debt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants