Switch out the envoy reverse proxy for caddy #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/retest |
Contributor
Author
|
looks like this failing test is due to a |
Contributor
Author
|
/retest |
SteveHNH
force-pushed
the
envoy_to_caddy
branch
from
5d6d725 to
ad589e8
Compare
psav
requested changes
Jan 2, 2024
Collaborator
psav
left a comment
psav
left a comment
There was a problem hiding this comment.
Happy to make these changes if you're too busy on return - just let me know
controllers/cloud.redhat.com/providers/web/caddy_reverse_proxy.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
Due to envoy no longer supporting RHEL8, we had to make a decision to switch to a different reverse proxy for TLS termination inside a pod. Caddy seemed like the obvious choice given that we already use it for other purposes. Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
SteveHNH
force-pushed
the
envoy_to_caddy
branch
from
e7fd885 to
f58482d
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
SteveHNH
force-pushed
the
envoy_to_caddy
branch
4 times, most recently
from
ff0b215 to
3161c67
Compare
Signed-off-by: Stephen Adams <stephen.adams@redhat.com>
SteveHNH
force-pushed
the
envoy_to_caddy
branch
from
3161c67 to
97b92cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy dropped support for the only version that will run on RHEL8 and no longer does security patches. This impacts secure environments since we can't use later images for envoy. Instead, we can swap out for caddy which effectively does the same thing
RHCLOUD-29123