Do not override env vars with empty values on IQE CJI #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that is found when using the
bonfire deploy-iqe-cjicommand. IfIQE_PLUGINSis not provided by the CJI, we expect it to be set by Clowder by looking up the ClowdApp.spec.testing.iqePluginvalue. However, if a CJI is applied with env var set to:{name: "IQE_PLUGINS", "value": ""}then the empty env var will end up being passed to the pod. This changes theupdateEnvVarsfunction to only override env vars when they have a non-empty value.