Added new ephem-msk mode #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psav
added
enhancement
Collaborator
Author
|
/retest |
adamrdrew
approved these changes
Oct 20, 2023
Contributor
adamrdrew
left a comment
adamrdrew
left a comment
There was a problem hiding this comment.
A hearty LGTM from me. This looks great. Test coverage so I feel safe. The code itself is short, sweet, and imminently readable and I have no questions.
wcmitchell
approved these changes
Oct 23, 2023
Contributor
wcmitchell
left a comment
wcmitchell
left a comment
There was a problem hiding this comment.
Lots to cover here, but overall looks good! Definitely think this is something we'll have to push out and let soak to see how it behaves live.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.