Add AdditionalFilters field to cindy spec [RHCLOUD-28098] #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
reviewed
Sep 7, 2023
Contributor
Author
|
/retest |
psav
requested changes
Sep 8, 2023
Collaborator
psav
left a comment
psav
left a comment
There was a problem hiding this comment.
I'm expecting to see a cyndi.go change here, without it nothing will happen, the new spec will be accepted, but it won't go anywhere. We should also add something to the tests - I think there is a test for cyndipipeline that ensures this field ends up in the right place.
gburges
force-pushed
the
cindystuff
branch
3 times, most recently
from
13ff144 to
ad06db2
Compare
psav
requested changes
Sep 8, 2023
Collaborator
psav
left a comment
psav
left a comment
There was a problem hiding this comment.
The test here only tests that the new field is acceptable - it doesn't actually assert that those fields land in the cyndipipeline resource
Contributor
Author
|
/retest |
gburges
force-pushed
the
cindystuff
branch
6 times, most recently
from
3e70dfe to
f84c53d
Compare
psav
requested changes
Sep 12, 2023
Collaborator
|
Need a rebase @gburges but, where are we on the cyndi release? |
Contributor
Author
rebased. Cyndi .12 got released already |
Collaborator
|
Can you rebase and fix conflicts please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL CYNDI RELEASES NEW VERSION