feat: Add prepush precommit hook so if we forget to make pre-push we get wa… #1034
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
secret restarter failing O.o /retest |
Contributor
Author
|
13:25:53 [2024-08-27T13:25:53.963Z] --- FAIL: kuttl/harness/test-annotations-job (506.47s) /retest |
bsquizz
previously requested changes
Aug 27, 2024
Contributor
bsquizz
left a comment
bsquizz
left a comment
There was a problem hiding this comment.
Just a couple picky suggestions:
- See the suggested change
- Can we rename
prepushtoprepush.shand add a newline at the end of file?
gburges
force-pushed
the
prepush
branch
4 times, most recently
from
03b0240 to
3adb22d
Compare
bsquizz
previously approved these changes
Aug 27, 2024
Victoremepunto
suggested changes
Aug 27, 2024
Contributor
There was a problem hiding this comment.
Please, can we add the lint step to the build Makefile goal instead of recurring to git hooks?
See here
Contributor
Author
|
/retest |
gburges
force-pushed
the
prepush
branch
8 times, most recently
from
5277d56 to
e49cec2
Compare
bsquizz
requested changes
Aug 27, 2024
gburges
force-pushed
the
prepush
branch
3 times, most recently
from
4795183 to
268d129
Compare
bsquizz
requested changes
Aug 27, 2024
bsquizz
previously requested changes
Aug 27, 2024
Contributor
bsquizz
left a comment
bsquizz
left a comment
There was a problem hiding this comment.
2 more things, then looks good to me ...
gburges
force-pushed
the
prepush
branch
2 times, most recently
from
555d5a1 to
b22f0a6
Compare
Contributor
Author
|
/retest |
gburges
force-pushed
the
prepush
branch
6 times, most recently
from
b74477c to
fd8b605
Compare
Contributor
Author
|
/retest |
Victoremepunto
previously requested changes
Aug 28, 2024
gburges
force-pushed
the
prepush
branch
5 times, most recently
from
b55c217 to
2c03279
Compare
psav
changed the title
gburges
force-pushed
the
prepush
branch
6 times, most recently
from
c75b232 to
38971fe
Compare
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rned