Make sure 'summary' field changes are also recorded#25
Merged
Conversation
Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added
bug
mhuth
approved these changes
Aug 11, 2025
PaulWay
added a commit
that referenced
this pull request
Sep 9, 2025
In investigating why the 'summary' field in many rules is the same as the 'generic' field, I found that changes to the 'summary' field were not being tracked in trying to determine whether to update the rule model of an existing rule. This fix makes sure that fields we check and possibly modify are always included in the list of fields checked for updates. (Hopefully) fixes RHINENG-17698 Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Sep 15, 2025
In investigating why the 'summary' field in many rules is the same as the 'generic' field, I found that changes to the 'summary' field were not being tracked in trying to determine whether to update the rule model of an existing rule. This fix makes sure that fields we check and possibly modify are always included in the list of fields checked for updates. (Hopefully) fixes RHINENG-17698 Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Feb 12, 2026
In investigating why the 'summary' field in many rules is the same as the 'generic' field, I found that changes to the 'summary' field were not being tracked in trying to determine whether to update the rule model of an existing rule. This fix makes sure that fields we check and possibly modify are always included in the list of fields checked for updates. (Hopefully) fixes RHINENG-17698 Signed-off-by: Paul Wayper <paulway@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In investigating why the 'summary' field in many rules is the same as the
'generic' field, I found that changes to the 'summary' field were not being
tracked in trying to determine whether to update the rule model of an
existing rule. This fix makes sure that fields we check and possibly modify
are always included in the list of fields checked for updates.
(Hopefully) fixes RHINENG-17698