The import_content code no longer runs as a script#11
Merged
Conversation
Signed-off-by: Paul Wayper <paulway@redhat.com>
Signed-off-by: Paul Wayper <paulway@redhat.com>
Collaborator
Author
|
Fixes RHINENG-17934 |
PaulWay
added
bug
mhuth
approved these changes
Jul 15, 2025
Collaborator
mhuth
left a comment
mhuth
left a comment
There was a problem hiding this comment.
Wow, I didn't realize those files were not needed at all!
vkrizan
approved these changes
Jul 15, 2025
| # Data is not valid for some reason. | ||
| return HttpResponseBadRequest("Config or content fields were not present") | ||
| return HttpResponseBadRequest( | ||
| content=b"Config or content fields were not present" |
Collaborator
There was a problem hiding this comment.
Is there any requirement to convert the strings to bytes?
Collaborator
Author
There was a problem hiding this comment.
Yes, the content sent by the HttpResponseBadRequest and other responses is in bytes; Django's been silently handling the conversion but this showed up in my type checking in Zed.
dkuc
approved these changes
Jul 15, 2025
PaulWay
added a commit
that referenced
this pull request
Jul 15, 2025
Previously, the `api/scripts/import_content.py` script was expected to run by itself and read files from the operating system. This is no longer supported. However, the legacy of this was that we tried to manually set up the Django environment, something that is now confusing parts of the WSGI loader. This manual setup can easily be removed. Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Jul 16, 2025
Previously, the `api/scripts/import_content.py` script was expected to run by itself and read files from the operating system. This is no longer supported. However, the legacy of this was that we tried to manually set up the Django environment, something that is now confusing parts of the WSGI loader. This manual setup can easily be removed. Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Aug 8, 2025
Previously, the `api/scripts/import_content.py` script was expected to run by itself and read files from the operating system. This is no longer supported. However, the legacy of this was that we tried to manually set up the Django environment, something that is now confusing parts of the WSGI loader. This manual setup can easily be removed. Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Sep 15, 2025
Previously, the `api/scripts/import_content.py` script was expected to run by itself and read files from the operating system. This is no longer supported. However, the legacy of this was that we tried to manually set up the Django environment, something that is now confusing parts of the WSGI loader. This manual setup can easily be removed. Signed-off-by: Paul Wayper <paulway@redhat.com>
PaulWay
added a commit
that referenced
this pull request
Feb 12, 2026
Previously, the `api/scripts/import_content.py` script was expected to run by itself and read files from the operating system. This is no longer supported. However, the legacy of this was that we tried to manually set up the Django environment, something that is now confusing parts of the WSGI loader. This manual setup can easily be removed. Signed-off-by: Paul Wayper <paulway@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
api/scripts/import_content.pyscript was expected to run byitself and read files from the operating system. This is no longer supported.
However, the legacy of this was that we tried to manually set up the Django
environment, something that is now confusing parts of the WSGI loader. This
manual setup can easily be removed.