Add Auto-dithering #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel J. Perry <dperry45@gatech.edu>
Signed-off-by: Daniel J. Perry <dperry45@gatech.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script should automatically resample the flac if it has a bit-depth higher than 16. This is what's done in the standard crawler tool for certain RecommdED sites, and I don't want to check each dir to see if it's 24-bit. I also added the mutagen dependancy because it becomes very cumbersome to get the information I need otherwise. Finally, I adjusted the help info to remove mention of
metaflacwhich is now optional only for replay-gain with flac, because themetaflacbinary should already be included with theflacpackage anyways.The mutagen module is only used to read the audio tags and not to write them, as it's better to use the encoders for that. I tested this commit by transcoding my entire music collection on my phone to MP3 V0. All of the tags are accounted for and it still sounds great.