WIP Optimize NodeRepository #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardelele
reviewed
Dec 18, 2020
| ClassModel<VideoNode> videoModel = ClassModel.builder(VideoNode.class).enableDiscriminator(true).build(); | ||
| ClassModel<Node> nodeModel = ClassModel.builder(Node.class).build(); | ||
|
|
||
| CodecRegistry pojoCodecRegistry = fromRegistries( |
Member
There was a problem hiding this comment.
I think we can create some factory for this PojoCodecRegistry.
Hardelele
reviewed
Dec 18, 2020
| import java.util.List; | ||
|
|
||
| public class NodeDao { | ||
| ClassModel<Parent> parent = ClassModel.builder(Parent.class).enableDiscriminator(true).build(); |
Member
There was a problem hiding this comment.
I would like to remove this hard coded part somehow. I will think how.
Hardelele
reviewed
Dec 18, 2020
| // * @return list of objects of class Node sorted by the selected parameter for sorting | ||
| // * in descending order | ||
| // */ | ||
| // public List<Node> findAllByTypeAndDesc(String sort, boolean desc) { |
Member
There was a problem hiding this comment.
Don't collect garbage in the code. If you complite with this part, then remove it.
Hardelele
approved these changes
Dec 18, 2020
Member
Hardelele
left a comment
Hardelele
left a comment
There was a problem hiding this comment.
Leave some comments, how we could improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.