Skip to content

Fix currency sub_unit values #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ninjasimon merged 1 commit into from
Apr 16, 2025
Merged

Fix currency sub_unit values #28

ninjasimon merged 1 commit into from
Apr 16, 2025

Conversation

@ninjasimon
Copy link
Contributor

@ninjasimon ninjasimon commented Apr 15, 2025 •
edited
Loading

Fixes values for sub_unit for many currencies.

  • When there are no fractional digits, sub_unit should be 1
  • When there are 3 fractional digits, sub_unit should be 1000
  • When there are 2 fractional digits, sub_unit should be 100

@ninjasimon ninjasimon self-assigned this Apr 15, 2025
@ninjasimon ninjasimon marked this pull request as ready for review April 15, 2025 22:23
@ninjasimon ninjasimon requested a review from a team as a code owner April 15, 2025 22:24
@ninjasimon ninjasimon merged commit bccd5e6 into main Apr 16, 2025
5 checks passed
@ninjasimon ninjasimon deleted the fix-sub_unit branch April 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashkarpetin ashkarpetin ashkarpetin approved these changes

@colinbird colinbird colinbird approved these changes

@justnero justnero justnero approved these changes

@albinoplant albinoplant albinoplant approved these changes

@i-yasko i-yasko i-yasko approved these changes

Assignees

@ninjasimon ninjasimon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ninjasimon @ashkarpetin @colinbird @justnero @albinoplant @i-yasko