fix(markdoc): remove horizontal rules#227
Merged
Merged
Conversation
noon-dawg
changed the title
noon-dawg
changed the title
Weetbix
requested changes
May 20, 2024
Collaborator
Weetbix
left a comment
Weetbix
left a comment
There was a problem hiding this comment.
Awesome!
Lets add a test case to readability.test.ts?
Weetbix
reviewed
May 20, 2024
| .use(addPeriodsToListItems) | ||
| .use(removeJsItems) | ||
| .use(removeUnwantedNodeTypes) | ||
| .use(removeHorizontalRules) |
Collaborator
There was a problem hiding this comment.
@noon-dawg Ah wait sorry, you'll see this breaks the existing YAML front matter unit test.
Likely you can swap the order so removeHorizontalRules plugin is used after removeFrontmatter.
Let me know if that doesn't work and we can think of another approach :)
Contributor
Author
There was a problem hiding this comment.
That works!! Thank you 🙏
Contributor
Author
|
(Added a test in 928fb1d) |
Weetbix
requested changes
May 27, 2024
Co-authored-by: Weetbix <weetbix_@hotmail.com>
Weetbix
previously approved these changes
May 27, 2024
Weetbix
force-pushed
the
remove-horizontal-lines
branch
from
9b74c2c to
b05479b
Compare
Weetbix
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes horizontal rules from the readability logic.