Skip to content

Set Django request object through a server method call #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

mizvyt
Copy link
Contributor

@mizvyt mizvyt commented Oct 25, 2019

Slight improvement to the way Django request object was handled previously.
This will simply let the backend set the request object to the server class instance, and have it consumed inside the server class.

This solves the issue with:

  • Dubious use of headers
  • Use of _-prefixed method from an internal library

This doesn't solve the issue of:

  • Passing duplicate data, as uri, http_method, body, headers are still passed along with the request

@PhilipGarnero PhilipGarnero merged commit 231d4b0 into RealmTeam:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants