Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force distance to be an int #305

Open
RealOrangeOne opened this issue Oct 17, 2022 · 2 comments
Open

Don't force distance to be an int #305

RealOrangeOne opened this issue Oct 17, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@RealOrangeOne
Copy link
Owner

Currently, the distance is required to be an int. Depending on what unit is used for measurements, this isn't always true. Changing to a float not only allows fractional distances, but by extension improves precision.

@RealOrangeOne RealOrangeOne added the good first issue Good for newcomers label Oct 17, 2022
@RealOrangeOne RealOrangeOne changed the title Distance must be an int Don't force distance to be an int Oct 17, 2022
PeterJCLaw added a commit to PeterJCLaw/zoloto that referenced this issue Nov 8, 2022
@PeterJCLaw
Copy link
Contributor

Note that there are quite a few PRs in flight which change a lot of the coordinates stuff, so work on this is likely to conflict with them.

@PeterJCLaw
Copy link
Contributor

A related and possibly desirable change may be to allow the specification of marker sizes as float, so that a more sensible unit can be used (currently consumers tend towards using millimetres due to the int limitation).

PeterJCLaw added a commit to PeterJCLaw/zoloto that referenced this issue Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants