Swallow and log any BaseException in ImmediateBackend other than KeyboardInterrupt #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthompson
changed the title
jhthompson
changed the title
jhthompson
commented
Jul 18, 2024
django_tasks/backends/immediate.py
Outdated
Comment on lines
47
to
48
| # Use `.exception` to integrate with error monitoring tools (eg Sentry) | ||
| logger.exception("Task execution failed: %s", e) |
There was a problem hiding this comment.
Should probably improve this message? I was looking at these lines from db_worker as an idea, but not sure if task_path is available here though:
# Use `.exception` to integrate with error monitoring tools (eg Sentry)
logger.exception(
"Task id=%s path=%s state=%s",
db_task_result.id,
db_task_result.task_path,
ResultStatus.FAILED,
)
There was a problem hiding this comment.
There's a module path on the Task you can use.
logfmt would also be great - there should be everything available here to replicate the message, you just might need to move the TaskResult creation above the execution for convenience.
There was a problem hiding this comment.
Pushed an improvement, I just used the result_id for the ID, is that fine?
jhthompson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50