Adding completion datetimes to the TaskResults (#31) #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find below a couple of things I would like to highlight (numbers for easier reference only):
enqueued_atfield as required and setting it totimezone.now()during the migration. As this only causes wrong enqueue times and we'll most likely squash migration pre-v1, I see no issues with that. Anything wrong with that reasoning?finished_attime of the DummyBackend to None. It is the intended behaviour of the DummyBackend to accept tasks, but not complete them by itself, correct?TaskResult.(a)refreshmethods through this PR, which asserts that thestatus,finished_atandresultreturned by the backend are actually used to update theTaskResult? That tests seems rather elaborate, while providing only little value. What do you think?