Skip to content

Conversation

@dennisstritzke
Copy link
Contributor

Find below a couple of things I would like to highlight (numbers for easier reference only):

  1. I introduced the enqueued_at field as required and setting it to timezone.now() during the migration. As this only causes wrong enqueue times and we'll most likely squash migration pre-v1, I see no issues with that. Anything wrong with that reasoning?
  2. I set the finished_at time of the DummyBackend to None. It is the intended behaviour of the DummyBackend to accept tasks, but not complete them by itself, correct?
  3. Do you think we should add a test for the TaskResult.(a)refresh methods through this PR, which asserts that the status, finished_at and result returned by the backend are actually used to update the TaskResult? That tests seems rather elaborate, while providing only little value. What do you think?

@dennisstritzke dennisstritzke force-pushed the completion-information branch from 4592207 to 4184506 Compare June 13, 2024 10:26
@RealOrangeOne RealOrangeOne linked an issue Jun 14, 2024 that may be closed by this pull request
@RealOrangeOne RealOrangeOne merged commit 082685f into RealOrangeOne:master Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completion information

2 participants